linux-kernel - Re: [PATCH v5 14/16] ufs: mcq: Add completion support of a cqe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <de0c1d8a-42bb-4e29-4da0-7b0cfc9c2ffe@acm.org>
Date:   Mon, 28 Nov 2022 09:47:41 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Manivannan Sadhasivam <mani@...nel.org>,
        Asutosh Das <quic_asutoshd@...cinc.com>
Cc:     quic_cang@...cinc.com, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org, quic_nguyenb@...cinc.com,
        quic_xiaosenh@...cinc.com, stanley.chu@...iatek.com,
        eddie.huang@...iatek.com, daejun7.park@...sung.com,
        avri.altman@....com, beanhuo@...ron.com,
        linux-arm-msm@...r.kernel.org,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Jinyoung Choi <j-young.choi@...sung.com>,
        Arthur Simchaev <Arthur.Simchaev@....com>,
        Kiwoong Kim <kwmad.kim@...sung.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 14/16] ufs: mcq: Add completion support of a cqe

On 11/28/22 09:00, Manivannan Sadhasivam wrote:
> On Tue, Nov 22, 2022 at 08:10:27PM -0800, Asutosh Das wrote:
>> Add support for completing requests from Completion Queue.
>> Some host controllers support vendor specific registers
>> that provide a bitmap of all CQ's which have at least one
>> completed CQE. Add this support.
>> The MCQ specification doesn't provide the Task Tag or its
>> equivalent in the Completion Queue Entry.
>> So use an indirect method to find the Task Tag from the
>> Completion Queue Entry.
>>
>> Co-developed-by: Can Guo <quic_cang@...cinc.com>
>> Signed-off-by: Can Guo <quic_cang@...cinc.com>
>> Signed-off-by: Asutosh Das <quic_asutoshd@...cinc.com>
>> Reported-by: kernel test robot <lkp@...el.com>
> 
> What is this reported by for?

I think that tag should be left out. "Reported-by: kernel test robot" 
should only be used for patches that fix bugs reported by the kernel 
test robot. I assume that a fix has been folded in into this patch that 
was reported by the kernel test robot. If that is the case, the 
"Reported-by: kernel test robot" tag is inappropriate.

Bart.