linux-kernel - Re: [PATCH] x86/asm: Remove unused COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221128141056.29ccafd6@gandalf.local.home>
Date:   Mon, 28 Nov 2022 14:10:56 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>,
        Vincent MAILHOL <mailhol.vincent@...adoo.fr>,
        kirill.shutemov@...ux.intel.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, hpa@...or.com, jpoimboe@...nel.org,
        linux-kernel@...r.kernel.org, mingo@...hat.com,
        sathyanarayanan.kuppuswamy@...ux.intel.com, tglx@...utronix.de,
        viro@...iv.linux.org.uk, x86@...nel.org
Subject: Re: [PATCH] x86/asm: Remove unused COMPILE_OFFSETS macro from
 asm-offsets.c

On Mon, 28 Nov 2022 18:06:18 +0000
Sean Christopherson <seanjc@...gle.com> wrote:

> > > IIRC, the reason for adding that was because that logic was screwing up
> > > asm-offsets.c. I'm not sure it screws up kvm-asm-offsets.c though.
> > > 
> > > This is one of those cases I wish I commented that code better :-/  
> > 
> > I don't think KVM includes linux/ftrace.h or asm/ftrace.h at all.  
> 
> >From include/linux/kvm_host.h  
> 
>   #include <linux/ftrace.h>
> 
> Even if that didn't exist, saying that XYZ never includes a header is a dangerous
> business, it's all too easy to indirectly include headers in the kernel, now or
> in the future.

But going back to the original intent of COMPILE_OFFSETS. I believe it was
because some code that did not work with the auto generation of compiler
offsets and was a way to hide them.

I do not know if it is still an issue or not today.

-- Steve