linux-kernel - RE: [PATCH v3 00/11] RTW88: Add support for USB variants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <71b14558ff904382a77b6b21982c078e@realtek.com>
Date:   Mon, 28 Nov 2022 03:45:57 +0000
From:   Ping-Ke Shih <pkshih@...ltek.com>
To:     Sascha Hauer <s.hauer@...gutronix.de>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
CC:     Neo Jou <neojou@...il.com>, Hans Ulli Kroll <linux@...i-kroll.de>,
        Yan-Hsuan Chuang <tony0620emma@...il.com>,
        Kalle Valo <kvalo@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Martin Blumenstingl" <martin.blumenstingl@...glemail.com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        Johannes Berg <johannes@...solutions.net>,
        Alexander Hochbaum <alex@...udo.com>,
        Da Xue <da@...re.computer>,
        "Bernie Huang" <phhuang@...ltek.com>,
        Viktor Petrenko <g0000ga@...il.com>
Subject: RE: [PATCH v3 00/11] RTW88: Add support for USB variants


> -----Original Message-----
> From: Sascha Hauer <s.hauer@...gutronix.de>
> Sent: Tuesday, November 22, 2022 10:52 PM
> To: linux-wireless@...r.kernel.org
> Cc: Neo Jou <neojou@...il.com>; Hans Ulli Kroll <linux@...i-kroll.de>; Ping-Ke Shih <pkshih@...ltek.com>;
> Yan-Hsuan Chuang <tony0620emma@...il.com>; Kalle Valo <kvalo@...nel.org>; netdev@...r.kernel.org;
> linux-kernel@...r.kernel.org; Martin Blumenstingl <martin.blumenstingl@...glemail.com>;
> kernel@...gutronix.de; Johannes Berg <johannes@...solutions.net>; Alexander Hochbaum <alex@...udo.com>;
> Da Xue <da@...re.computer>; Bernie Huang <phhuang@...ltek.com>; Viktor Petrenko <g0000ga@...il.com>;
> Sascha Hauer <s.hauer@...gutronix.de>
> Subject: [PATCH v3 00/11] RTW88: Add support for USB variants
> 
> This is the third round of adding support for the USB variants to the
> RTW88 driver. There are a few changes to the last version which make it
> worth looking at this version.
> 
> First of all RTL8723du and RTL8821cu are tested working now. The issue
> here was that the txdesc checksum calculation was wrong. I found the
> correct calculation in various downstream drivers found on github.
> 
> The second big issue was that TX packet aggregation was wrong. When
> aggregating packets each packet start has to be aligned to eight bytes.
> The necessary alignment was added to the total URB length before
> checking if there is another packet to aggregate, so the URB length
> included that padding after the last packet, which is wrong.  Fixing
> this makes the driver work much more reliably.
> 

Thanks for your finding and fixes on this driver. I have reviewed this 
patchset and written some comments. No big problem.


> 
> Sascha Hauer (11):
>   rtw88: print firmware type in info message
>   rtw88: Call rtw_fw_beacon_filter_config() with rtwdev->mutex held
>   rtw88: Drop rf_lock
>   rtw88: Drop h2c.lock
>   rtw88: Drop coex mutex
>   rtw88: iterate over vif/sta list non-atomically
>   rtw88: Add common USB chip support
>   rtw88: Add rtw8821cu chipset support
>   rtw88: Add rtw8822bu chipset support
>   rtw88: Add rtw8822cu chipset support
>   rtw88: Add rtw8723du chipset support

Please use "wifi: rtw88: " as prefix in next version.

--
Ping-Ke