linux-kernel - Re: [PATCH -next] selftests/landlock: Fix selftest ptrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1232e4f3-e4b8-ff23-61e8-5465c8406f6e@digikod.net>
Date:   Mon, 28 Nov 2022 20:44:44 +0100
From:   Mickaël Salaün <mic@...ikod.net>
To:     limin <limin100@...wei.com>, shuah@...nel.org,
        linux-kselftest@...r.kernel.org,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     hannes@...xchg.org, mhocko@...nel.org, roman.gushchin@...ux.dev,
        shakeelb@...gle.com, songmuchun@...edance.com, tj@...nel.org,
        lizefan.x@...edance.com
Subject: Re: [PATCH -next] selftests/landlock: Fix selftest ptrace_test run
 fail

This patch changes the test semantic and then cannot work on my test 
environment. On which kernel did you run test? Do you use Yama or 
something similar?

On 28/11/2022 03:04, limin wrote:
> Tests PTRACE_ATTACH and PTRACE_MODE_READ on the parent,
> trace parent return -1 when child== 0
> How to reproduce warning:
> $ make -C tools/testing/selftests TARGETS=landlock run_tests
> 
> Signed-off-by: limin <limin100@...wei.com>
> ---
>   tools/testing/selftests/landlock/ptrace_test.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/landlock/ptrace_test.c b/tools/testing/selftests/landlock/ptrace_test.c
> index c28ef98ff3ac..88c4dc63eea0 100644
> --- a/tools/testing/selftests/landlock/ptrace_test.c
> +++ b/tools/testing/selftests/landlock/ptrace_test.c
> @@ -267,12 +267,11 @@ TEST_F(hierarchy, trace)
>   		/* Tests PTRACE_ATTACH and PTRACE_MODE_READ on the parent. */
>   		err_proc_read = test_ptrace_read(parent);
>   		ret = ptrace(PTRACE_ATTACH, parent, NULL, 0);
> +		EXPECT_EQ(-1, ret);
> +		EXPECT_EQ(EPERM, errno);
>   		if (variant->domain_child) {
> -			EXPECT_EQ(-1, ret);
> -			EXPECT_EQ(EPERM, errno);
>   			EXPECT_EQ(EACCES, err_proc_read);
>   		} else {
> -			EXPECT_EQ(0, ret);
>   			EXPECT_EQ(0, err_proc_read);
>   		}
>   		if (ret == 0) {