[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CACRpkda1sdqxnP0Lc2qnWOq5PH4_8vTvNiwn3ibE7+uZwLv0Gg@mail.gmail.com>
Date: Mon, 28 Nov 2022 21:42:16 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
Andy Shevchenko <andy@...nel.org>, stable@...r.kernel.org,
Dale Smith <dalepsmith@...il.com>,
John Harris <jmharris@...il.com>
Subject: Re: [PATCH v1 1/1] pinctrl: intel: Save and restore pins in "direct
IRQ" mode
On Thu, Nov 24, 2022 at 11:29 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
> The firmware on some systems may configure GPIO pins to be
> an interrupt source in so called "direct IRQ" mode. In such
> cases the GPIO controller driver has no idea if those pins
> are being used or not. At the same time, there is a known bug
> in the firmwares that don't restore the pin settings correctly
> after suspend, i.e. by an unknown reason the Rx value becomes
> inverted.
>
> Hence, let's save and restore the pins that are configured
> as GPIOs in the input mode with GPIROUTIOXAPIC bit set.
>
> Cc: stable@...r.kernel.org
> Reported-and-tested-by: Dale Smith <dalepsmith@...il.com>
> Reported-and-tested-by: John Harris <jmharris@...il.com>
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=214749
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>
> Linus, I hope that this can still make v6.1 release. I'm not going to
> send a PR for this change unless you insist.
Patch applied for fixes, plan is to get it to Torvalds
ASAP!
Yours,
Linus Walleij
Powered by blists - more mailing lists