linux-kernel - Re: [PATCH] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Enable ADSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1912229.PYKUYFuaPT@g550jk>
Date:   Mon, 28 Nov 2022 22:06:15 +0100
From:   Luca Weiss <luca@...tu.xyz>
To:     Matti Lehtimäki <matti.lehtimaki@...il.com>,
        linux-arm-msm@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Konrad Dybcio <konrad.dybcio@...aro.org>
Subject: Re: [PATCH] ARM: dts: qcom: apq8026-samsung-matisse-wifi: Enable ADSP

On Montag, 28. November 2022 21:59:06 CET Konrad Dybcio wrote:
> On 28.11.2022 18:01, Matti Lehtimäki wrote:
> > On 28.11.2022 16.41, Konrad Dybcio wrote:
> >> On 25.11.2022 23:34, Matti Lehtimäki wrote:
> >>> diff --git a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
> >>> b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts index
> >>> 1c52337af560..859e91c16c61 100644
> >>> --- a/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
> >>> +++ b/arch/arm/boot/dts/qcom-apq8026-samsung-matisse-wifi.dts
> >>> @@ -133,7 +133,8 @@ wcnss@...0000 {
> >>>               no-map;
> >>>           };
> >>>   -        adsp@...0000 {
> >>> +        /delete-node/ adsp@...0000;
> >> 
> >> Please delete nodes by referencing the label like so:
> >> 
> >> /delete-node/ &adsp_region;
> > 
> > When I created the devicetree I was asked to do the opposite for the
> > smem_region [1] which I had originally deleted using the label near top of
> > the file but then moved next to the relevant node, where I cannot use
> > label when deleting it. Should the smem_region also be moved to the top
> > of the file if I move this delete-node there so the file would be
> > consistent?
> In [1] you were asked to move the delete-node statement, not to alter
> the argument. Referencing nodes by label is allowed globally in the DTS.
> The removal should stay inside reserved-memory.

Having e.g. this doesn't build, you get "syntax error" error

  reserved-memory {
      /delete-node/ &venus_region;
  };

Not sure exactly why, but that's the reason everything's outside of the root 
node if you use labels (don't ask me why labels lead to syntax error but 
specifying the name manually works)

> 
> Konrad
> 
> > [1]
> > https://lore.kernel.org/linux-arm-msm/CAA8EJpqUH_v1GXEYF62Z3DBtFu_305_h4D
> > 36aCnBr38bo5HoJw@...l.gmail.com/