[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Y4QzyPgDPt11iHlM@gondor.apana.org.au>
Date: Mon, 28 Nov 2022 12:06:32 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Catalin Marinas <catalin.marinas@....com>
Cc: Ard Biesheuvel <ardb@...nel.org>, Will Deacon <will@...nel.org>,
Marc Zyngier <maz@...nel.org>, Arnd Bergmann <arnd@...db.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Linux Memory Management List <linux-mm@...ck.org>,
Linux ARM <linux-arm-kernel@...ts.infradead.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
"David S. Miller" <davem@...emloft.net>,
Linux Crypto Mailing List <linux-crypto@...r.kernel.org>
Subject: Re: [v2 PATCH 3/9] crypto: aead - Add ctx helpers with DMA alignment
On Fri, Nov 25, 2022 at 12:24:31PM +0000, Catalin Marinas wrote:
>
> I wonder, if drivers end up calling this, isn't it easier to do the
> alignment in crypto_aead_ctx() directly? There are over 300 callers (not
> sure about the padding though, it may need still driver changes unless
> we can add it to something like crypto_tfm_alg_alignmask()). Or is the
> expectation that not all drivers need a DMA alignment?
I'm only changing the specific drivers that map things from the ctx
structures for DMA. So it's not as bad as a simple grep would suggest.
Cheers,
--
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists