linux-kernel - Re: [PATCH v2 rcu 12/16] scsi/scsi_error: Use call_rcu_flush() instead of call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 28 Nov 2022 13:39:30 -0800
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Bart Van Assche <bvanassche@....org>
Cc:     rcu@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-team@...a.com, rostedt@...dmis.org,
        Uladzislau Rezki <urezki@...il.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org
Subject: Re: [PATCH v2 rcu 12/16] scsi/scsi_error: Use call_rcu_flush()
 instead of call_rcu()

On Fri, Nov 25, 2022 at 04:11:26PM -0800, Bart Van Assche wrote:
> On 11/21/22 17:04, Paul E. McKenney wrote:
> > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> > index 6995c89792300..634672e67c81f 100644
> > --- a/drivers/scsi/scsi_error.c
> > +++ b/drivers/scsi/scsi_error.c
> > @@ -312,7 +312,7 @@ void scsi_eh_scmd_add(struct scsi_cmnd *scmd)
> >   	 * Ensure that all tasks observe the host state change before the
> >   	 * host_failed change.
> >   	 */
> > -	call_rcu(&scmd->rcu, scsi_eh_inc_host_failed);
> > +	call_rcu_flush(&scmd->rcu, scsi_eh_inc_host_failed);
> >   }
> 
> Reviewed-by: Bart Van Assche <bvanassche@....org>

Thank you both, I will apply these on the next rebase.

							Thanx, Paul