linux-kernel - Re: [PATCH 1/2] ASoC: qcom: lpass-sc7180: Drop unnecessary initialization in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=Wi3Oy9kdFfP6WE1wbtSrGxsr_VC8KZQAyTMgW-uMTOWA@mail.gmail.com>
Date:   Mon, 28 Nov 2022 14:37:24 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Matthias Kaehlcke <mka@...omium.org>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Banajit Goswami <bgoswami@...cinc.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>,
        linux-kernel@...r.kernel.org, Judy Hsiao <judyhsiao@...gle.com>
Subject: Re: [PATCH 1/2] ASoC: qcom: lpass-sc7180: Drop unnecessary
 initialization in _resume()

Hi,

On Mon, Nov 28, 2022 at 2:12 PM Matthias Kaehlcke <mka@...omium.org> wrote:
>
> The initialization of the variable 'ret' in sc7180_lpass_dev_resume()
> is unnecessary, as it is always assigned a few lines below. Drop the
> initialization.
>
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
> ---
>
>  sound/soc/qcom/lpass-sc7180.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Not that this needs review, but FWIW:

Reviewed-by: Douglas Anderson <dianders@...omium.org>