linux-kernel - Re: [PATCH v2 1/2] drm/amdgpu: Temporarily disable broken Clang builds due to blown stack-frame

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 27 Nov 2022 22:52:38 -0700
From:   Nathan Chancellor <nathan@...nel.org>
To:     Lee Jones <lee@...nel.org>
Cc:     arnd@...db.de, akpm@...ux-foundation.org,
        maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
        tzimmermann@...e.de, airlied@...il.com, daniel@...ll.ch,
        ndesaulniers@...gle.com, trix@...hat.com, harry.wentland@....com,
        sunpeng.li@....com, Rodrigo.Siqueira@....com,
        alexander.deucher@....com, christian.koenig@....com,
        Xinhui.Pan@....com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2 1/2] drm/amdgpu: Temporarily disable broken Clang
 builds due to blown stack-frame

On Fri, Nov 25, 2022 at 12:07:49PM +0000, Lee Jones wrote:
> calculate_bandwidth() is presently broken on all !(X86_64 || SPARC64 || ARM64)
> architectures built with Clang (all released versions), whereby the stack
> frame gets blown up to well over 5k.  This would cause an immediate kernel
> panic on most architectures.  We'll revert this when the following bug report
> has been resolved: https://github.com/llvm/llvm-project/issues/41896.
> 
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Lee Jones <lee@...nel.org>

Reviewed-by: Nathan Chancellor <nathan@...nel.org>

> ---
>  drivers/gpu/drm/amd/display/Kconfig | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/Kconfig b/drivers/gpu/drm/amd/display/Kconfig
> index 6925e0280dbe6..f4f3d2665a6b2 100644
> --- a/drivers/gpu/drm/amd/display/Kconfig
> +++ b/drivers/gpu/drm/amd/display/Kconfig
> @@ -5,6 +5,7 @@ menu "Display Engine Configuration"
>  config DRM_AMD_DC
>  	bool "AMD DC - Enable new display engine"
>  	default y
> +	depends on BROKEN || !CC_IS_CLANG || X86_64 || SPARC64 || ARM64
>  	select SND_HDA_COMPONENT if SND_HDA_CORE
>  	select DRM_AMD_DC_DCN if (X86 || PPC_LONG_DOUBLE_128)
>  	help
> @@ -12,6 +13,12 @@ config DRM_AMD_DC
>  	  support for AMDGPU. This adds required support for Vega and
>  	  Raven ASICs.
>  
> +	  calculate_bandwidth() is presently broken on all !(X86_64 || SPARC64 || ARM64)
> +	  architectures built with Clang (all released versions), whereby the stack
> +	  frame gets blown up to well over 5k.  This would cause an immediate kernel
> +	  panic on most architectures.  We'll revert this when the following bug report
> +	  has been resolved: https://github.com/llvm/llvm-project/issues/41896.
> +
>  config DRM_AMD_DC_DCN
>  	def_bool n
>  	help
> -- 
> 2.38.1.584.g0f3c55d4c2-goog
>