linux-kernel - [PATCH -next] selftests/ptrace: Fix Test terminated by timeout in ptrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221128070454.1850273-1-limin100@huawei.com>
Date:   Mon, 28 Nov 2022 15:04:54 +0800
From:   limin <limin100@...wei.com>
To:     <shuah@...nel.org>, <keescook@...omium.org>,
        <bernd.edlinger@...mail.de>, <ebiederm@...ssion.com>,
        <linux-kselftest@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <songmuchun@...edance.com>, <lizefan.x@...edance.com>
Subject: [PATCH -next] selftests/ptrace: Fix Test terminated by timeout in ptrace_attach

That is an open issue
Bernd Edlinger wrote the test case in anticipation that all of
patch series got accepted,but the last patch was not picked up
for inclusion in the linux kernel.
How to reproduce warning:
$ make -C tools/testing/selftests TARGETS=ptrace run_tests
Example vmaccess from 6.1.0-next source tree run fail on bare metal
  RUN global.attach ...
  attach: Test terminated by timeout
  FAIL  global.attach

Link:https://lore.kernel.org/all/AM8PR10MB4708E6FF0E155261455064C2E4209@AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM/
Fixes: 2de4e82318c7 ("selftests/ptrace: add test cases for dead-locks")
Signed-off-by: limin <limin100@...wei.com>
---
 tools/testing/selftests/ptrace/vmaccess.c | 37 ++++++++---------------
 1 file changed, 13 insertions(+), 24 deletions(-)

diff --git a/tools/testing/selftests/ptrace/vmaccess.c b/tools/testing/selftests/ptrace/vmaccess.c
index 4db327b44586..751a41f1163c 100644
--- a/tools/testing/selftests/ptrace/vmaccess.c
+++ b/tools/testing/selftests/ptrace/vmaccess.c
@@ -45,42 +45,31 @@ TEST(vmaccess)
 
 TEST(attach)
 {
-	int s, k, pid = fork();
+	int k;
+	int s;
 
+	pid_t pid = fork();
 	if (!pid) {
-		pthread_t pt;
-
-		pthread_create(&pt, NULL, thread, NULL);
-		pthread_join(pt, NULL);
+		ptrace(PTRACE_TRACEME, 0, NULL, NULL);
 		execlp("sleep", "sleep", "2", NULL);
 	}
 
 	sleep(1);
 	k = ptrace(PTRACE_ATTACH, pid, 0L, 0L);
-	ASSERT_EQ(errno, EAGAIN);
+	printf("k1:%d\n", k);
+	ASSERT_EQ(k, -1);
+	waitpid(pid, &s, WNOHANG);
 	ASSERT_EQ(k, -1);
-	k = waitpid(-1, &s, WNOHANG);
-	ASSERT_NE(k, -1);
 	ASSERT_NE(k, 0);
 	ASSERT_NE(k, pid);
-	ASSERT_EQ(WIFEXITED(s), 1);
-	ASSERT_EQ(WEXITSTATUS(s), 0);
-	sleep(1);
-	k = ptrace(PTRACE_ATTACH, pid, 0L, 0L);
-	ASSERT_EQ(k, 0);
-	k = waitpid(-1, &s, 0);
-	ASSERT_EQ(k, pid);
+	if (WIFEXITED(s))
+		ASSERT_EQ(WEXITSTATUS(s), 0);
+	if (WIFSTOPPED(s))
+		ASSERT_EQ(WSTOPSIG(s), SIGTRAP);
 	ASSERT_EQ(WIFSTOPPED(s), 1);
-	ASSERT_EQ(WSTOPSIG(s), SIGSTOP);
-	k = ptrace(PTRACE_DETACH, pid, 0L, 0L);
-	ASSERT_EQ(k, 0);
-	k = waitpid(-1, &s, 0);
-	ASSERT_EQ(k, pid);
-	ASSERT_EQ(WIFEXITED(s), 1);
-	ASSERT_EQ(WEXITSTATUS(s), 0);
-	k = waitpid(-1, NULL, 0);
+	sleep(1);
+	ptrace(PTRACE_CONT, pid, NULL, NULL);
 	ASSERT_EQ(k, -1);
-	ASSERT_EQ(errno, ECHILD);
 }
 
 TEST_HARNESS_MAIN
-- 
2.33.0