linux-kernel - Re: linux-next: build warnings after merge of the v4l-dvb-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <28948ae.13ac1.184bd24def0.Coremail.linma@zju.edu.cn>
Date:   Mon, 28 Nov 2022 15:30:21 +0800 (GMT+08:00)
From:   "Lin Ma" <linma@....edu.cn>
To:     "Stephen Rothwell" <sfr@...b.auug.org.au>
Cc:     "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        "Linux Next Mailing List" <linux-next@...r.kernel.org>
Subject: Re: linux-next: build warnings after merge of the v4l-dvb-next tree

Hi Stephen,

> Hi all,
> 
> After merging the v4l-dvb-next tree, today's linux-next build (htmldocs)
> produced these warnings:
> 
> include/media/dvbdev.h:193: warning: Function parameter or member 'ref' not described in 'dvb_device'
> include/media/dvbdev.h:207: warning: expecting prototype for dvb_device_get(). Prototype was for dvb_device_put() instead
> 
> Introduced by commit
> 
>   0fc044b2b5e2 ("media: dvbdev: adopts refcnt to avoid UAF")
> 
> -- 

Oh my bad, it seems that I leave a typo there as forgetting about the function name in comment.

/**
 * dvb_device_get - Decrease dvb_device reference
 *
 * @dvbdev:	pointer to struct dvb_device
 */
void dvb_device_put(struct dvb_device *dvbdev);

Also the 'ref' field is not described with comment. Will send the fix to the v4l-dvb-next soon.

Thanks
Lin