[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221128082108.ntjhevb4ku6lnvib@houat>
Date: Mon, 28 Nov 2022 09:21:08 +0100
From: Maxime Ripard <maxime@...no.tech>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>, Helge Deller <deller@....de>,
Michael Schmitz <schmitzmic@...il.com>,
dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
linux-m68k@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH/RFC 2/3] drm/simple-kms-helper: Add mode_fixup() to
simple display pipe
Hi,
On Fri, Nov 25, 2022 at 09:31:09PM +0100, Geert Uytterhoeven wrote:
> From: Thomas Zimmermann <tzimmermann@...e.de>
>
> The mode fix-up function for simple display helpers is equivalent to the
> regular pipeline's CRTC mode fix-up function. It's called to adjust the
> CRTC's display mode for the encoder. Add this function for DRM fbconv
> helpers.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@...e.de>
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
It's not clear to me why you'd need a mode_fixup in the first place.
Like said in the documentation you added, atomic_check is usually the
better option for the atomic modesetting drivers.
So, why is it needed?
Maxime
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists