linux-kernel - [PATCH v2] soc: imx8m: Fix return value check in imx8mq_soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221128083755.80445-1-zhengyongjun3@huawei.com>
Date:   Mon, 28 Nov 2022 08:37:55 +0000
From:   Zheng Yongjun <zhengyongjun3@...wei.com>
To:     <shawnguo@...nel.org>, <s.hauer@...gutronix.de>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
CC:     <kernel@...gutronix.de>, <festevam@...il.com>, <linux-imx@....com>
Subject: [PATCH v2] soc: imx8m: Fix return value check in imx8mq_soc_revision()

In case of error, the function of_clk_get_by_name()
returns ERR_PTR() and never returns NULL. The NULL test in the
return value check should be replaced with IS_ERR().

Fixes: 836fb30949d9 ("soc: imx8m: Enable OCOTP clock before reading the register")
Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
---
Changes in v2:
- Rewrite code and make it more concise.
 drivers/soc/imx/soc-imx8m.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
index 28144c699b0c..d1dbe318be53 100644
--- a/drivers/soc/imx/soc-imx8m.c
+++ b/drivers/soc/imx/soc-imx8m.c
@@ -66,10 +66,8 @@ static u32 __init imx8mq_soc_revision(void)
 	ocotp_base = of_iomap(np, 0);
 	WARN_ON(!ocotp_base);
 	clk = of_clk_get_by_name(np, NULL);
-	if (!clk) {
-		WARN_ON(!clk);
+	if (WARN_ON(IS_ERR(clk)))
 		return 0;
-	}

 	clk_prepare_enable(clk);

--
2.17.1