[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20221128084421.8626-1-niejianglei2021@163.com>
Date: Mon, 28 Nov 2022 16:44:21 +0800
From: Jianglei Nie <niejianglei2021@....com>
To: ojeda@...nel.org, andriy.shevchenko@...ux.intel.com,
geert+renesas@...der.be
Cc: linux-kernel@...r.kernel.org,
Jianglei Nie <niejianglei2021@....com>,
kernel test robot <lkp@...el.com>
Subject: [PATCH v2] auxdisplay: hd44780: Fix potential memory leak in hd44780_remove()
hd44780_probe() allocates a memory chunk for hd with kzalloc() and
makes "lcd->drvdata->hd44780" point to it. When we call hd44780_remove(),
we should release all relevant memory and resource. But "lcd->drvdata
->hd44780" is not released, which will lead to a memory leak.
We should release the "lcd->drvdata->hd44780" in hd44780_remove() to fix
the memory leak bug.
Fixes: 41c8d0adf3c4 ("auxdisplay: hd44780: Fix memory leak on ->remove()")
Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: Jianglei Nie <niejianglei2021@....com>
---
drivers/auxdisplay/hd44780.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/auxdisplay/hd44780.c b/drivers/auxdisplay/hd44780.c
index 8b2a0eb3f32a..f4800a946bd8 100644
--- a/drivers/auxdisplay/hd44780.c
+++ b/drivers/auxdisplay/hd44780.c
@@ -322,8 +322,10 @@ static int hd44780_probe(struct platform_device *pdev)
static int hd44780_remove(struct platform_device *pdev)
{
struct charlcd *lcd = platform_get_drvdata(pdev);
+ struct hd44780_common *hdc = (struct hd44780_common *)lcd->drvdata;
charlcd_unregister(lcd);
+ kfree(hdc->hd44780);
kfree(lcd->drvdata);
kfree(lcd);
--
2.25.1
Powered by blists - more mailing lists