linux-kernel - Re: [PATCH linux-next] RDMA/mlx4: NULL check before dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 28 Nov 2022 11:50:38 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     zhang.songyi@....com.cn
Cc:     yishaih@...dia.com, jgg@...pe.ca, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH linux-next] RDMA/mlx4: NULL check before dev_{put, hold}
 functions is not? needed

On Wed, Nov 23, 2022 at 05:08:25PM +0800, zhang.songyi@....com.cn wrote:
> From: zhang songyi <zhang.songyi@....com.cn>
> 
> The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> so there is no need to check before using dev_{put, hold}.
> 
> Fix the following coccicheck warnings:
> /drivers/infiniband/hw/mlx4/main.c:1311:2-10: WARNING:
> WARNING  NULL check before dev_{put, hold} functions is not needed.
> 
> /drivers/infiniband/hw/mlx4/main.c:148:2-10: WARNING:
> WARNING  NULL check before dev_{put, hold} functions is not needed.
> 
> /drivers/infiniband/hw/mlx4/main.c:1959:3-11: WARNING:
> WARNING  NULL check before dev_{put, hold} functions is not needed.
> 
> /drivers/infiniband/hw/mlx4/main.c:1962:3-10: WARNING:
> WARNING  NULL check before dev_{put, hold} functions is not needed.
> 
> Signed-off-by: zhang songyi <zhang.songyi@....com.cn>
> ---
>  drivers/infiniband/hw/mlx4/main.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)

This patch doesn't apply to rdma-next tree.
Please fix commit title "not?" -> "not" and resubmit.

Thanks