linux-kernel - Re: [PATCH] usb: gadget: udc: drop obsolete dependencies on COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <717e921f-af8f-f235-e2f8-e2fae2b31e9a@microchip.com>
Date:   Mon, 28 Nov 2022 11:59:14 +0100
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     Jean Delvare <jdelvare@...e.de>, <linux-usb@...r.kernel.org>
CC:     LKML <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Michal Simek <michal.simek@...inx.com>
Subject: Re: [PATCH] usb: gadget: udc: drop obsolete dependencies on
 COMPILE_TEST

On 25/11/2022 at 17:04, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
> 
> It is actually better to always build such drivers with OF enabled,
> so that the test builds are closer to how each driver will actually be
> built on its intended target. Building them without OF may not test
> much as the compiler will optimize out potentially large parts of the
> code. In the worst case, this could even pop false positive warnings.
> Dropping COMPILE_TEST here improves the quality of our testing and
> avoids wasting time on non-existent issues.
> 
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>

Fine with me:
Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

Thanks Jean. Best regards,
   Nicolas

> Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>
> Cc: Claudiu Beznea <claudiu.beznea@...rochip.com>
> Cc: Michal Simek <michal.simek@...inx.com>
> ---
>   drivers/usb/gadget/udc/Kconfig |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-6.0.orig/drivers/usb/gadget/udc/Kconfig
> +++ linux-6.0/drivers/usb/gadget/udc/Kconfig
> @@ -33,7 +33,7 @@ menu "USB Peripheral Controller"
>   config USB_AT91
>          tristate "Atmel AT91 USB Device Port"
>          depends on ARCH_AT91
> -       depends on OF || COMPILE_TEST
> +       depends on OF
>          help
>             Many Atmel AT91 processors (such as the AT91RM2000) have a
>             full speed USB Device Port with support for five configurable
> @@ -430,7 +430,7 @@ config USB_EG20T
>   config USB_GADGET_XILINX
>          tristate "Xilinx USB Driver"
>          depends on HAS_DMA
> -       depends on OF || COMPILE_TEST
> +       depends on OF
>          help
>            USB peripheral controller driver for Xilinx USB2 device.
>            Xilinx USB2 device is a soft IP which supports both full
> 
> 
> --
> Jean Delvare
> SUSE L3 Support

-- 
Nicolas Ferre