lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Nov 2022 01:36:24 +0000 From: Dexuan Cui <decui@...rosoft.com> To: "Michael Kelley (LINUX)" <mikelley@...rosoft.com>, "ak@...ux.intel.com" <ak@...ux.intel.com>, "arnd@...db.de" <arnd@...db.de>, "bp@...en8.de" <bp@...en8.de>, "brijesh.singh@....com" <brijesh.singh@....com>, "Williams, Dan J" <dan.j.williams@...el.com>, "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>, Haiyang Zhang <haiyangz@...rosoft.com>, "hpa@...or.com" <hpa@...or.com>, "jane.chu@...cle.com" <jane.chu@...cle.com>, "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>, KY Srinivasan <kys@...rosoft.com>, "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>, "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>, "luto@...nel.org" <luto@...nel.org>, "mingo@...hat.com" <mingo@...hat.com>, "peterz@...radead.org" <peterz@...radead.org>, "rostedt@...dmis.org" <rostedt@...dmis.org>, "sathyanarayanan.kuppuswamy@...ux.intel.com" <sathyanarayanan.kuppuswamy@...ux.intel.com>, "seanjc@...gle.com" <seanjc@...gle.com>, "tglx@...utronix.de" <tglx@...utronix.de>, "tony.luck@...el.com" <tony.luck@...el.com>, "wei.liu@...nel.org" <wei.liu@...nel.org>, "x86@...nel.org" <x86@...nel.org> CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH 5/6] x86/hyperv: Support hypercalls for TDX guests > From: Michael Kelley (LINUX) <mikelley@...rosoft.com> > Sent: Sunday, November 27, 2022 5:21 PM > > [...] > > +u64 hv_tdx_hypercall(u64 control, u64 input_addr, u64 output_addr) > > +{ > > + struct tdx_hypercall_args args = { }; > > + > > + if (!(control & HV_HYPERCALL_FAST_BIT)) { > > + if (input_addr) > > + input_addr += ms_hyperv.shared_gpa_boundary; > > At one point when working with the vTOM code, I realized that or'ing in > the shared_gpa_boundary is probably safer than add'ing it, just in case > the physical address already has vTOM set. I don't know if that possibility > exists here, but it's something to consider as being slightly more robust. > > > + > > + if (output_addr) > > + output_addr += ms_hyperv.shared_gpa_boundary; > > Same here. Ok, will use |= in all the reference.
Powered by blists - more mailing lists