[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221128111112.dzavip4eqqgpyrai@box.shutemov.name>
Date: Mon, 28 Nov 2022 14:11:12 +0300
From: kirill.shutemov@...ux.intel.com
To: Vincent Mailhol <mailhol.vincent@...adoo.fr>
Cc: bp@...en8.de, dave.hansen@...ux.intel.com, hpa@...or.com,
jpoimboe@...nel.org, linux-kernel@...r.kernel.org,
mingo@...hat.com, pbonzini@...hat.com, rostedt@...dmis.org,
sathyanarayanan.kuppuswamy@...ux.intel.com, seanjc@...gle.com,
tglx@...utronix.de, viro@...iv.linux.org.uk, x86@...nel.org
Subject: Re: [PATCH] x86/asm: Remove unused COMPILE_OFFSETS macro from
asm-offsets.c
On Mon, Nov 28, 2022 at 07:11:17PM +0900, Vincent Mailhol wrote:
> On Mon, 28 Nov 2022 12:15:06 +0300, Kirill A. Shutemov wrote:
> > On Sun, Nov 27, 2022 at 03:23:35PM +0900, Vincent Mailhol wrote:
> > > Following [1], the macro COMPILE_OFFSETS becomes unused:
> >
> > Really? I see #ifdef COMPILE_OFFSETS in ftrace.h. Hm?
> >
> > Have you tested your patch with CONFIG_FTRACE_SYSCALLS=y and
> > CONFIG_IA32_EMULATION=y?
>
> Even if I activate those two configurations, the compiler still
> tells me it is unused:
>
> $ grep -E "CONFIG_FTRACE_SYSCALLS|CONFIG_IA32_EMULATION" .config
> CONFIG_IA32_EMULATION=y
> CONFIG_FTRACE_SYSCALLS=y
>
> $ make W=2 arch/x86/kernel/asm-offsets.o
> <...>
> arch/x86/kernel/asm-offsets.c:7: warning: macro "COMPILE_OFFSETS" is not used [-Wunused-macros]
> <...>
If you are sure <asm/ftrace.h> is never included from asm-offsets.c,
remove #ifndef COMPILE_OFFSETS too.
--
Kiryl Shutsemau / Kirill A. Shutemov
Powered by blists - more mailing lists