[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <19ef6b09-678c-cf9d-7f91-684e6d00e6a9@marcan.st>
Date: Mon, 28 Nov 2022 20:35:29 +0900
From: Hector Martin <marcan@...can.st>
To: Sven Peter <sven@...npeter.dev>, Arnd Bergmann <arnd@...db.de>
Cc: Alyssa Rosenzweig <alyssa@...enzweig.io>, asahi@...ts.linux.dev,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] soc: apple: rtkit: Stop casting function pointer
signatures
On 05/11/2022 00.41, Sven Peter wrote:
> Fixes: 9bd1d9a0d8bb ("soc: apple: Add RTKit IPC library")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Sven Peter <sven@...npeter.dev>
> ---
> drivers/soc/apple/rtkit.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/soc/apple/rtkit.c b/drivers/soc/apple/rtkit.c
> index ecc1a818b23d..fa3cda831d2b 100644
> --- a/drivers/soc/apple/rtkit.c
> +++ b/drivers/soc/apple/rtkit.c
> @@ -922,8 +922,10 @@ int apple_rtkit_wake(struct apple_rtkit *rtk)
> }
> EXPORT_SYMBOL_GPL(apple_rtkit_wake);
>
> -static void apple_rtkit_free(struct apple_rtkit *rtk)
> +static void apple_rtkit_free(void *data)
> {
> + struct apple_rtkit *rtk = data;
> +
> mbox_free_channel(rtk->mbox_chan);
> destroy_workqueue(rtk->wq);
>
> @@ -946,8 +948,7 @@ struct apple_rtkit *devm_apple_rtkit_init(struct device *dev, void *cookie,
> if (IS_ERR(rtk))
> return rtk;
>
> - ret = devm_add_action_or_reset(dev, (void (*)(void *))apple_rtkit_free,
> - rtk);
> + ret = devm_add_action_or_reset(dev, apple_rtkit_free, rtk);
> if (ret)
> return ERR_PTR(ret);
>
Applied to asahi-soc/soc, thanks!
- Hector
Powered by blists - more mailing lists