linux-kernel - [PATCH linux-next] tracing: move from strlcpy with unused retval to strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202211282002156712454@zte.com.cn>
Date:   Mon, 28 Nov 2022 20:02:15 +0800 (CST)
From:   <zhang.songyi@....com.cn>
To:     <rostedt@...dmis.org>
Cc:     <mhiramat@...nel.org>, <linux-kernel@...r.kernel.org>,
        <zhang.songyi@....com.cn>
Subject: [PATCH linux-next] tracing: move from strlcpy with unused retval to strscpy

From: zhang songyi <zhang.songyi@....com.cn>

Follow the advice of the below link and prefer 'strscpy' in this
subsystem. That's now the recommended way to copy NUL terminated
strings. Conversion is 1:1 because the return value is not used.

Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
Signed-off-by: zhang songyi <zhang.songyi@....com.cn>
---
 kernel/trace/trace_events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 3bfaf560ecc4..a43be36c489e 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -2813,7 +2813,7 @@ static __init int setup_trace_triggers(char *str)
        char *buf;
        int i;

-       strlcpy(bootup_trigger_buf, str, COMMAND_LINE_SIZE);
+       strscpy(bootup_trigger_buf, str, COMMAND_LINE_SIZE);
        ring_buffer_expanded = true;
        disable_tracing_selftest("running event triggers");

--
2.15.2