linux-kernel - Re: [PATCH v4 1/2] EDAC/qcom: Get rid of hardcoded register offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4SmtfSzLbYea+f0@zn.tnic>
Date:   Mon, 28 Nov 2022 13:16:53 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     bjorn.andersson@...aro.org, mchehab@...nel.org,
        james.morse@....com, rric@...nel.org,
        linux-arm-msm@...r.kernel.org, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org, quic_saipraka@...cinc.com
Subject: Re: [PATCH v4 1/2] EDAC/qcom: Get rid of hardcoded register offsets

On Wed, Nov 16, 2022 at 08:03:51PM +0530, Manivannan Sadhasivam wrote:
> The LLCC EDAC register offsets varies between each SoC. Hardcoding the
> register offsets won't work and will often result in crash due to
> accessing the wrong locations.
> 
> Hence, get the register offsets from the LLCC driver matching the
> individual SoCs.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> ---
>  drivers/edac/qcom_edac.c           | 116 ++++++++++++++---------------
>  include/linux/soc/qcom/llcc-qcom.h |   6 --
>  2 files changed, 58 insertions(+), 64 deletions(-)

It looks to me like this patch needs to go to stable?

Also, the Fixes tag should probably be:

Fixes: 27450653f1db ("drivers: edac: Add EDAC driver support for QCOM SoCs")

Yes, no?

Also, please explain to me how you've tested this patch if it doesn't
even build?!

ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/soc/qcom/llcc-qcom.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:126: Module.symvers] Error 1
make: *** [Makefile:1944: modpost] Error 2

I guess because CONFIG_QCOM_LLCC is =y in your config while I have
CONFIG_QCOM_LLCC=m.

And I reported the same build error to you the last time. Did you not
see it?

For the next version, you'd need to fix all possible Kconfig build
errors before sending.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette