[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c752d17e-23fd-4452-e1d8-6c82748b6c8a@intel.com>
Date: Mon, 28 Nov 2022 05:18:12 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: "Huang, Kai" <kai.huang@...el.com>,
"kvm@...r.kernel.org" <kvm@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc: "Luck, Tony" <tony.luck@...el.com>,
"bagasdotme@...il.com" <bagasdotme@...il.com>,
"ak@...ux.intel.com" <ak@...ux.intel.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
"kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
"Christopherson,, Sean" <seanjc@...gle.com>,
"Chatre, Reinette" <reinette.chatre@...el.com>,
"pbonzini@...hat.com" <pbonzini@...hat.com>,
"linux-mm@...ck.org" <linux-mm@...ck.org>,
"Yamahata, Isaku" <isaku.yamahata@...el.com>,
"peterz@...radead.org" <peterz@...radead.org>,
"Shahar, Sagi" <sagis@...gle.com>,
"imammedo@...hat.com" <imammedo@...hat.com>,
"Gao, Chao" <chao.gao@...el.com>,
"Brown, Len" <len.brown@...el.com>,
"sathyanarayanan.kuppuswamy@...ux.intel.com"
<sathyanarayanan.kuppuswamy@...ux.intel.com>,
"Huang, Ying" <ying.huang@...el.com>,
"Williams, Dan J" <dan.j.williams@...el.com>
Subject: Re: [PATCH v7 14/20] x86/virt/tdx: Set up reserved areas for all
TDMRs
On 11/28/22 01:14, Huang, Kai wrote:
> On Wed, 2022-11-23 at 15:39 -0800, Dave Hansen wrote:
...
>> /*
>> * Go through tdx_memlist to find holes between memory areas. If any of
>> * those holes fall within @tdmr, set up a TDMR reserved area to cover
>> * the hole.
>> */
>> static int tdmr_populate_rsvd_holes(struct list_head *tdx_memlist,
>> struct tdmr_info *tdmr,
>> int *rsvd_idx)
>
> Thanks!
>
> Should I also change below function 'tdmr_set_up_pamt_rsvd_areas()' to, i.e.
> tdmr_populate_rsvd_pamts()?
>
> Actually, there are two more functions in this patch: tdmr_set_up_rsvd_areas()
> and tdmrs_set_up_rsvd_areas_all(). Should I also change them to
> tdmr_populate_rsvd_areas() and tdmrs_populate_rsvd_areas_all()?
I don't know. I'll look at the naming again once I see it all together.
>> but I also get the feeling that 'prev_end' is a crummy variable name. I
>> don't have any better suggestions at the moment.
>>
>>> + list_for_each_entry(tmb, &tdx_memlist, list) {
>>> + u64 start, end;
>>> +
>>> + start = tmb->start_pfn << PAGE_SHIFT;
>>> + end = tmb->end_pfn << PAGE_SHIFT;
>>> +
>>
>> More alignment opportunities:
>>
>> start = tmb->start_pfn << PAGE_SHIFT;
>> end = tmb->end_pfn << PAGE_SHIFT;
>
> Should I use PFN_PHYS()? Then looks we don't need this alignment.
Sure.
Powered by blists - more mailing lists