linux-kernel - Re: [PATCH v1 1/2] i2c: loongson: add bus driver for the loongson i2c controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y4S20yF+vB1atRFz@smile.fi.intel.com>
Date:   Mon, 28 Nov 2022 15:25:39 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Yinbo Zhu <zhuyinbo@...ngson.cn>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Jean Delvare <jdelvare@...e.de>,
        William Zhang <william.zhang@...adcom.com>,
        Conor Dooley <conor.dooley@...rochip.com>,
        Jan Dabros <jsd@...ihalf.com>,
        Tharun Kumar P <tharunkumar.pasumarthi@...rochip.com>,
        Phil Edworthy <phil.edworthy@...esas.com>,
        Sam Protsenko <semen.protsenko@...aro.org>,
        Tyrone Ting <kfting@...oton.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] i2c: loongson: add bus driver for the loongson
 i2c controller

On Mon, Nov 28, 2022 at 09:13:02PM +0800, Yinbo Zhu wrote:
> 在 2022/11/17 16:44, Andy Shevchenko 写道:
> > On Thu, Nov 17, 2022 at 03:59:37PM +0800, Yinbo Zhu wrote:

...

> > > +start:
> > > +	mdelay(1);
> > Why?
> This is a workaroud.

You need to add a comment explaining that in details.

-- 
With Best Regards,
Andy Shevchenko