[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6b445991-0843-6a1e-1bd0-1980a78a0481@linaro.org>
Date: Mon, 28 Nov 2022 14:32:13 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Sarannya S <quic_sarannya@...cinc.com>, bjorn.andersson@...aro.org,
arnaud.pouliquen@...s.st.com, swboyd@...omium.org,
quic_clew@...cinc.com, mathieu.poirier@...aro.org
Cc: linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
linux-remoteproc@...r.kernel.org,
Deepak Kumar Singh <quic_deesin@...cinc.com>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Shawn Guo <shawnguo@...nel.org>, Arnd Bergmann <arnd@...db.de>,
Marcel Ziswiler <marcel.ziswiler@...adex.com>,
Vinod Koul <vkoul@...nel.org>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Mark Brown <broonie@...nel.org>,
"moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V4 1/3] rpmsg: core: Add signal API support
On 28/11/2022 14:28, Sarannya S wrote:
> Some transports like Glink support the state notifications between
> clients using flow control signals similar to serial protocol signals.
> Local glink client drivers can send and receive flow control status
> to glink clients running on remote processors.
>
> Add APIs to support sending and receiving of flow control status by
> rpmsg clients.
>
> Signed-off-by: Deepak Kumar Singh <quic_deesin@...cinc.com>
> ---
> arch/arm64/configs/defconfig | 2 ++
Thank you for your patch. There is something to discuss/improve.
defconfig changes are not related with code, please keep separate with
their own explanation.
> drivers/rpmsg/rpmsg_core.c | 20 ++++++++++++++++++++
> drivers/rpmsg/rpmsg_internal.h | 2 ++
> include/linux/rpmsg.h | 15 +++++++++++++++
> 4 files changed, 39 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 0b6af33..2df3778 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -26,6 +26,8 @@ CONFIG_CGROUP_CPUACCT=y
> CONFIG_CGROUP_PERF=y
> CONFIG_CGROUP_BPF=y
> CONFIG_USER_NS=y
> +CONFIG_RPMSG=y
> +CONFIG_RPMSG_CHAR=y
Why? It is already =m
I don't think this is correct patch hunk...
Best regards,
Krzysztof
Powered by blists - more mailing lists