lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Nov 2022 14:47:43 +0100 From: Takashi Iwai <tiwai@...e.de> To: Ricardo Ribalda <ribalda@...omium.org> Cc: Kai Vehmanen <kai.vehmanen@...ux.intel.com>, Jaroslav Kysela <perex@...ex.cz>, Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>, Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>, Mark Brown <broonie@...nel.org>, Daniel Baluta <daniel.baluta@....com>, Bard Liao <yung-chuan.liao@...ux.intel.com>, Takashi Iwai <tiwai@...e.com>, Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>, Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org, alsa-devel@...a-project.org, stable@...r.kernel.org, sound-open-firmware@...a-project.org Subject: Re: [PATCH v4] ALSA: core: Fix deadlock when shutdown a frozen userspace On Mon, 28 Nov 2022 14:42:49 +0100, Ricardo Ribalda wrote: > > During kexec(), the userspace is frozen. Therefore we cannot wait for it > to complete. > > Avoid running snd_sof_machine_unregister during shutdown. > > This fixes: > > [ 84.943749] Freezing user space processes ... (elapsed 0.111 seconds) done. > [ 246.784446] INFO: task kexec-lite:5123 blocked for more than 122 seconds. > [ 246.819035] Call Trace: > [ 246.821782] <TASK> > [ 246.824186] __schedule+0x5f9/0x1263 > [ 246.828231] schedule+0x87/0xc5 > [ 246.831779] snd_card_disconnect_sync+0xb5/0x127 > ... > [ 246.889249] snd_sof_device_shutdown+0xb4/0x150 > [ 246.899317] pci_device_shutdown+0x37/0x61 > [ 246.903990] device_shutdown+0x14c/0x1d6 > [ 246.908391] kernel_kexec+0x45/0xb9 > > And: > > [ 246.893222] INFO: task kexec-lite:4891 blocked for more than 122 seconds. > [ 246.927709] Call Trace: > [ 246.930461] <TASK> > [ 246.932819] __schedule+0x5f9/0x1263 > [ 246.936855] ? fsnotify_grab_connector+0x5c/0x70 > [ 246.942045] schedule+0x87/0xc5 > [ 246.945567] schedule_timeout+0x49/0xf3 > [ 246.949877] wait_for_completion+0x86/0xe8 > [ 246.954463] snd_card_free+0x68/0x89 > ... > [ 247.001080] platform_device_unregister+0x12/0x35 > > Cc: stable@...r.kernel.org > Fixes: 83bfc7e793b5 ("ASoC: SOF: core: unregister clients and machine drivers in .shutdown") > Signed-off-by: Ricardo Ribalda <ribalda@...omium.org> > --- > To: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com> > To: Liam Girdwood <lgirdwood@...il.com> > To: Peter Ujfalusi <peter.ujfalusi@...ux.intel.com> > To: Bard Liao <yung-chuan.liao@...ux.intel.com> > To: Ranjani Sridharan <ranjani.sridharan@...ux.intel.com> > To: Kai Vehmanen <kai.vehmanen@...ux.intel.com> > To: Daniel Baluta <daniel.baluta@....com> > To: Mark Brown <broonie@...nel.org> > To: Jaroslav Kysela <perex@...ex.cz> > To: Takashi Iwai <tiwai@...e.com> > Cc: sound-open-firmware@...a-project.org > Cc: alsa-devel@...a-project.org > Cc: linux-kernel@...r.kernel.org > --- > Changes in v4: > - Do not call snd_sof_machine_unregister from shutdown. > - Link to v3: https://lore.kernel.org/r/20221127-snd-freeze-v3-0-a2eda731ca14@chromium.org The subject prefix should be adjusted -- now it's no longer about ALSA core but specific to ASoC SOF. thanks, Takashi
Powered by blists - more mailing lists