linux-kernel - Re: [PATCH] arm64: dts: xilinx: align LED node names with dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9f3a9cb0-1c48-ec6e-d07a-77cedee2408e@amd.com>
Date:   Mon, 28 Nov 2022 15:28:14 +0100
From:   Michal Simek <michal.simek@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Michal Simek <michal.simek@...inx.com>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: xilinx: align LED node names with dtschema



On 11/25/22 15:41, Krzysztof Kozlowski wrote:
> CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.
> 
> 
> The node names should be generic and DT schema expects certain pattern:
> 
>    xilinx/zynqmp-zcu100-revC.dtb: leds: 'vbus-det' does not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>   arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> index d61a297a2090..6948fd40554b 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> @@ -86,7 +86,7 @@ led-ds5 {
>                          linux,default-trigger = "bluetooth-power";
>                  };
> 
> -               vbus-det { /* U5 USB5744 VBUS detection via MIO25 */
> +               led-vbus-det { /* U5 USB5744 VBUS detection via MIO25 */
>                          label = "vbus_det";
>                          gpios = <&gpio 25 GPIO_ACTIVE_HIGH>;
>                          default-state = "on";
> --
> 2.34.1
> 

Applied.
M