[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <f27edbcf-91b6-3a9a-7fb3-96298ebb6009@intel.com>
Date: Mon, 28 Nov 2022 08:37:29 -0700
From: Dave Jiang <dave.jiang@...el.com>
To: Jiasheng Jiang <jiasheng@...as.ac.cn>, jdmason@...zu.us,
allenbh@...il.com, error27@...il.com
Cc: ntb@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] NTB: ntb_tool: Add check for devm_kcalloc
On 11/21/2022 8:32 PM, Jiasheng Jiang wrote:
> As the devm_kcalloc may return NULL pointer,
> it should be better to add check for the return
> value, as same as the others.
>
> Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support")
> Signed-off-by: Jiasheng Jiang <jiasheng@...as.ac.cn>
Reviewed-by: Dave Jiang <dave.jiang@...el.com>
> ---
> drivers/ntb/test/ntb_tool.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
> index 5ee0afa621a9..eeeb4b1c97d2 100644
> --- a/drivers/ntb/test/ntb_tool.c
> +++ b/drivers/ntb/test/ntb_tool.c
> @@ -998,6 +998,8 @@ static int tool_init_mws(struct tool_ctx *tc)
> tc->peers[pidx].outmws =
> devm_kcalloc(&tc->ntb->dev, tc->peers[pidx].outmw_cnt,
> sizeof(*tc->peers[pidx].outmws), GFP_KERNEL);
> + if (tc->peers[pidx].outmws == NULL)
> + return -ENOMEM;
>
> for (widx = 0; widx < tc->peers[pidx].outmw_cnt; widx++) {
> tc->peers[pidx].outmws[widx].pidx = pidx;
Powered by blists - more mailing lists