[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d2113f20-d547-ce16-ff7f-2d1286321014@lwfinger.net>
Date: Tue, 29 Nov 2022 10:59:46 -0600
From: Larry Finger <Larry.Finger@...inger.net>
To: Jakub Kicinski <kuba@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>
Cc: linux-wireless@...r.kernel.org, Neo Jou <neojou@...il.com>,
Hans Ulli Kroll <linux@...i-kroll.de>,
Ping-Ke Shih <pkshih@...ltek.com>,
Yan-Hsuan Chuang <tony0620emma@...il.com>,
Kalle Valo <kvalo@...nel.org>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
kernel@...gutronix.de, Johannes Berg <johannes@...solutions.net>,
Alexander Hochbaum <alex@...udo.com>,
Da Xue <da@...re.computer>, Po-Hao Huang <phhuang@...ltek.com>,
Viktor Petrenko <g0000ga@...il.com>
Subject: Re: [PATCH v4 08/11] wifi: rtw88: Add rtw8821cu chipset support
On 11/29/22 10:17, Jakub Kicinski wrote:
> On Tue, 29 Nov 2022 11:07:51 +0100 Sascha Hauer wrote:
>> +config RTW88_8821CU
>> + tristate "Realtek 8821CU USB wireless network adapter"
>> + depends on USB
>> + select RTW88_CORE
>> + select RTW88_USB
>> + select RTW88_8821C
>> + help
>> + Select this option will enable support for 8821CU chipset
>> +
>> + 802.11ac USB wireless network adapter
>
> Those kconfig knobs add so little code, why not combine them all into
> one? No point bothering the user with 4 different questions with amount
> to almost nothing.
I see only one knob there, name RTW88_8821CU. The other configuration variables
select parts of the code that are shared with other drivers such as RTW88_8821CE
and these parts must be there.
Larry
Powered by blists - more mailing lists