[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221129201149.GA2131686@roeck-us.net>
Date: Tue, 29 Nov 2022 12:13:13 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Rob Clark <robdclark@...il.com>
Cc: dri-devel@...ts.freedesktop.org,
Rob Clark <robdclark@...omium.org>,
open list <linux-kernel@...r.kernel.org>,
stable@...r.kernel.org, Eric Anholt <eric@...olt.net>,
Noralf Trønnes <noralf@...nnes.org>,
Thomas Zimmermann <tzimmermann@...e.de>
Subject: Re: [1/2] drm/shmem-helper: Remove errant put in error path
On Tue, Nov 29, 2022 at 12:02:41PM -0800, Rob Clark wrote:
> From: Rob Clark <robdclark@...omium.org>
>
> drm_gem_shmem_mmap() doesn't own this reference!
>
I think the impact should be explained further.
> Fixes: 2194a63a818d ("drm: Add library for shmem backed GEM objects")
> Cc: stable@...r.kernel.org
> Signed-off-by: Rob Clark <robdclark@...omium.org>
> ---
> drivers/gpu/drm/drm_gem_shmem_helper.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c
> index 35138f8a375c..110a9eac2af8 100644
> --- a/drivers/gpu/drm/drm_gem_shmem_helper.c
> +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c
> @@ -623,7 +623,6 @@ int drm_gem_shmem_mmap(struct drm_gem_shmem_object *shmem, struct vm_area_struct
>
> ret = drm_gem_shmem_get_pages(shmem);
> if (ret) {
> - drm_gem_vm_close(vma);
> return ret;
> }
Drop the now unnecessary { }
Also, consider adding Reported-by: and possibly Suggested-by:.
Thanks,
Guenter
Powered by blists - more mailing lists