lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <45793334-f890-d0e6-dd3a-6335ed0628f8@linuxfoundation.org> Date: Tue, 29 Nov 2022 14:54:46 -0700 From: Shuah Khan <skhan@...uxfoundation.org> To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>, linux-kernel@...r.kernel.org, x86@...nel.org Cc: Roland Mainz <roland.mainz@...bsig.org>, "H. Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>, Ingo Molnar <mingo@...hat.com>, Thomas Gleixner <tglx@...utronix.de>, Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org> Subject: Re: [PATCH 3/3] selftests: Make a warning if getcpu is missing on 32bit. On 11/25/22 02:42, Sebastian Andrzej Siewior wrote: > The vsyscall for getcpu has been wired up on 32bit so it can be warned > now if missing. > > Cc: Shuah Khan <shuah@...nel.org> > Cc: linux-kselftest@...r.kernel.org > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de> > --- > tools/testing/selftests/x86/test_vsyscall.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/x86/test_vsyscall.c b/tools/testing/selftests/x86/test_vsyscall.c > index 5b45e6986aeab..47cab972807c4 100644 > --- a/tools/testing/selftests/x86/test_vsyscall.c > +++ b/tools/testing/selftests/x86/test_vsyscall.c > @@ -92,11 +92,8 @@ static void init_vdso(void) > printf("[WARN]\tfailed to find time in vDSO\n"); > > vdso_getcpu = (getcpu_t)dlsym(vdso, "__vdso_getcpu"); > - if (!vdso_getcpu) { > - /* getcpu() was never wired up in the 32-bit vDSO. */ > - printf("[%s]\tfailed to find getcpu in vDSO\n", > - sizeof(long) == 8 ? "WARN" : "NOTE"); > - } > + if (!vdso_getcpu) > + printf("[WARN]\tfailed to find getcpu in vDSO\n"); > } > > static int init_vsys(void) Assuming this is going through x86 tree due to dependencies, here is my ack Acked-by: Shuah Khan <skhan@...uxfoundation.org> Let me know if you would like to me pick this up. thanks, -- Shuah
Powered by blists - more mailing lists