linux-kernel - Re: [PATCH v1 net 2/2] vmxnet3: use correct intrConf reference when using extended queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4137D072-6887-47A5-9652-0F0A5FFBE329@vmware.com>
Date:   Tue, 29 Nov 2022 00:35:27 +0000
From:   Ronak Doshi <doshir@...are.com>
To:     Jacob Keller <jacob.e.keller@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Pv-drivers <Pv-drivers@...are.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Guolin Yang <gyang@...are.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 net 2/2] vmxnet3: use correct intrConf reference when
 using extended queues


On 11/28/22, 3:49 PM, "Jacob Keller" <jacob.e.keller@...el.com> wrote:
>     !! External Email
>
>     On 11/28/2022 11:32 AM, Ronak Doshi wrote:
>    > 'Commit 39f9895a00f4 ("vmxnet3: add support for 32 Tx/Rx queues")'
>    > added support for 32Tx/Rx queues. As a part of this patch, intrConf
>    > structure was extended to incorporate increased queues.
>    >
>
>     Nit: no need to quote around the commit reference here.
>
>     I don't personally think its worth a re-roll to fix that, but good to be
>     aware of in future submission.
>
>     The patch itself makes sense.
>
>     Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

Thanks, Jacob, for the review.