linux-kernel - Re: [PATCH v2] USB: FHCI: fix error return code in of_fhci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c8b9e41-dabb-f6f6-04e7-778c91a6b432@huawei.com>
Date:   Tue, 29 Nov 2022 14:24:44 +0800
From:   wangyufen <wangyufen@...wei.com>
To:     <gregkh@...uxfoundation.org>, <linus.walleij@...aro.org>,
        <mailhol.vincent@...adoo.fr>
CC:     <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] USB: FHCI: fix error return code in of_fhci_probe()

Please ignore.

Thanks.

在 2022/11/29 14:41, Wang Yufen 写道:
> Fix to return a negative error code of PTR_ERR(fhci->gpiods[i])
> instead of 0.
> 
> Fixes: a4efdb8a423b ("USB: FHCI: Switch to GPIO descriptors")
> Signed-off-by: Wang Yufen <wangyufen@...wei.com>
> ---
>   drivers/usb/host/fhci-hcd.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c
> index 95a4446..ca4b311 100644
> --- a/drivers/usb/host/fhci-hcd.c
> +++ b/drivers/usb/host/fhci-hcd.c
> @@ -639,8 +639,9 @@ static int of_fhci_probe(struct platform_device *ofdev)
>   					NULL, i, GPIOD_OUT_LOW);
>   
>   		if (IS_ERR(fhci->gpiods[i])) {
> -			dev_err(dev, "incorrect GPIO%d: %ld\n",
> -				i, PTR_ERR(fhci->gpiods[i]));
> +			ret = PTR_ERR(fhci->gpiods[i])
> +			dev_err(dev, "incorrect GPIO%d: %d\n",
> +				i, ret);
>   			goto err_gpios;
>   		}
>   		if (!fhci->gpiods[i]) {