linux-kernel - Re: [PATCH] media: platform: Fix missing error code in rzg2l_cru_start_streaming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f53b0b08-3f35-184e-5be4-3143192e3e44@xs4all.nl>
Date:   Tue, 29 Nov 2022 08:34:02 +0100
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, mchehab@...nel.org
Cc:     p.zabel@...gutronix.de, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] media: platform: Fix missing error code in
 rzg2l_cru_start_streaming_vq()

Hi Jiapeng Chong,

Please repost with a proper subject line prefix: "media: rzg2l-cru:".

The 'media: platform:' prefix suggests a media/platform-wide patch, not a patch
for a single driver.

Why is this so hard to do?

Regards,

	Hans


On 29/11/2022 04:17, Jiapeng Chong wrote:
> Failed to allocate scratch buffer, add the error code '-ENOMEM' to the
> return value 'ret'.
> 
> drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:676 rzg2l_cru_start_streaming_vq() warn: missing error code 'ret'.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3275
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> index 9533e4069ecd..91b57c7c2e56 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> @@ -673,6 +673,7 @@ static int rzg2l_cru_start_streaming_vq(struct vb2_queue *vq, unsigned int count
>  	if (!cru->scratch) {
>  		return_unused_buffers(cru, VB2_BUF_STATE_QUEUED);
>  		dev_err(cru->dev, "Failed to allocate scratch buffer\n");
> +		ret = -ENOMEM;
>  		goto free_image_conv_irq;
>  	}
>