linux-kernel - Re: [PATCH 2/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix warning in example (missing reg property)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <657e7d50-7352-1a4f-6977-cf1d9c6e6c8e@linaro.org>
Date:   Tue, 29 Nov 2022 09:06:07 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Jonathan Neuschäfer <j.neuschaefer@....net>,
        linux-spi@...r.kernel.org, Mark Brown <broonie@...nel.org>
Cc:     Conor Dooley <conor.dooley@...rochip.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>, openbmc@...ts.ozlabs.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Subject: Re: [PATCH 2/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix warning in
 example (missing reg property)

On 28/11/2022 22:49, Jonathan Neuschäfer wrote:
> I forgot to add a "reg = <0>;" property to the flash@0 node while
> writing the example. Fix this.

Don't be personal in commit messages. Instead:
   Add missing "reg = <0>;" property to the flash@0 node in the example.

which has the same amount of information and is even shorter.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

> 
> Fixes: dd71cd4dd6c9b ("spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU) bindings")
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>


Best regards,
Krzysztof