[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a7a705b5-64b1-e735-9f1c-5318c2bdf5db@linaro.org>
Date: Tue, 29 Nov 2022 09:09:45 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Naresh Solanki <naresh.solanki@...ements.com>,
devicetree@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>,
Jean Delvare <jdelvare@...e.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc: linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
Patrick Rudolph <patrick.rudolph@...ements.com>
Subject: Re: [PATCH v7 1/4] dt-bindings: hwmon: fan: Add fan binding to schema
On 21/11/2022 13:29, Naresh Solanki wrote:
> Add common fan properties bindings to a schema.
>
> Bindings for fan controllers can reference the common schema for the
> fan
>
> child nodes:
>
> patternProperties:
> "^fan@[0-2]":
> type: object
> $ref: fan-common.yaml#
>
> Signed-off-by: Naresh Solanki <Naresh.Solanki@...ements.com>
> ---
> .../devicetree/bindings/hwmon/fan-common.yaml | 47 +++++++++++++++++++
> 1 file changed, 47 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/fan-common.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/fan-common.yaml b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
> new file mode 100644
> index 000000000000..0535d37624cc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/fan-common.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Common fan properties
I responded to v6, so let me paste here as well:
Common Fan Properties
> +
> +maintainers:
> + - Naresh Solanki <naresh.solanki@...ements.com>
> +
> +properties:
> + max-rpm:
> + description:
> + Max RPM supported by fan.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + min-rpm:
> + description:
> + Min RPM supported by fan.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + pulses-per-revolution:
> + description:
> + The number of pulse from fan sensor per revolution.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + target-rpm:
> + description:
> + Target RPM the fan should be configured during driver probe.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + pwms:
> + description:
> + PWM provider.
Maybe:
type: object
> +
Best regards,
Krzysztof
Powered by blists - more mailing lists