[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221129083306.GB24762@lst.de>
Date: Tue, 29 Nov 2022 09:33:06 +0100
From: Christoph Hellwig <hch@....de>
To: Jinlong Chen <nickyc975@....edu.cn>
Cc: axboe@...nel.dk, hch@....de, linux-block@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] elevator: replace continue with else-if in
elv_iosched_show
On Fri, Nov 25, 2022 at 11:53:12PM +0800, Jinlong Chen wrote:
> list_for_each_entry(e, &elv_list, list) {
> - if (e == cur) {
> + if (e == cur)
> len += sprintf(name+len, "[%s] ", cur->elevator_name);
> - continue;
> - }
> - if (elv_support_features(q, e))
> + else if (elv_support_features(q, e))
> len += sprintf(name+len, "%s ", e->elevator_name);
Looks good. But to make this even more obvious I'd also switch to
pinting e->elevator_name for the cur case instead of cur.
Powered by blists - more mailing lists