| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CO1PR11MB5089CA1EA56FE7CFF70F6046D6129@CO1PR11MB5089.namprd11.prod.outlook.com>
Date: Tue, 29 Nov 2022 01:19:46 +0000
From: "Keller, Jacob E" <jacob.e.keller@...el.com>
To: Vincent MAILHOL <mailhol.vincent@...adoo.fr>
CC: Jiri Pirko <jiri@...dia.com>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
Jakub Kicinski <kuba@...nel.org>,
"David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
"Paolo Abeni" <pabeni@...hat.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Boris Brezillon <bbrezillon@...nel.org>,
Arnaud Ebalard <arno@...isbad.org>,
Srujana Challa <schalla@...vell.com>,
Kurt Kanzenbach <kurt@...utronix.de>,
Andrew Lunn <andrew@...n.ch>,
"Florian Fainelli" <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>,
Michael Chan <michael.chan@...adcom.com>,
Ioana Ciornei <ioana.ciornei@....com>,
Dimitris Michailidis <dmichail@...gible.com>,
"Yisen Zhuang" <yisen.zhuang@...wei.com>,
Salil Mehta <salil.mehta@...wei.com>,
"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
Sunil Goutham <sgoutham@...vell.com>,
"Linu Cherian" <lcherian@...vell.com>,
Geetha sowjanya <gakula@...vell.com>,
"Jerin Jacob" <jerinj@...vell.com>,
hariprasad <hkelam@...vell.com>,
"Subbaraya Sundeep" <sbhatta@...vell.com>,
Taras Chornyi <tchornyi@...vell.com>,
"Saeed Mahameed" <saeedm@...dia.com>,
Leon Romanovsky <leon@...nel.org>,
"Ido Schimmel" <idosch@...dia.com>,
Petr Machata <petrm@...dia.com>,
Simon Horman <simon.horman@...igine.com>,
Shannon Nelson <snelson@...sando.io>,
"drivers@...sando.io" <drivers@...sando.io>,
Ariel Elior <aelior@...vell.com>,
Manish Chopra <manishc@...vell.com>,
Jonathan Lemon <jonathan.lemon@...il.com>,
Vadim Fedorenko <vadfed@...com>,
Richard Cochran <richardcochran@...il.com>,
Vadim Pasternak <vadimp@...lanox.com>,
"linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
"oss-drivers@...igine.com" <oss-drivers@...igine.com>,
Jiri Pirko <jiri@...lanox.com>,
Herbert Xu <herbert@...dor.apana.org.au>,
Guangbin Huang <huangguangbin2@...wei.com>,
Minghao Chi <chi.minghao@....com.cn>,
"Shijith Thotton" <sthotton@...vell.com>
Subject: RE: [PATCH net-next v5 2/4] net: devlink: remove
devlink_info_driver_name_put()
> -----Original Message-----
> From: Vincent MAILHOL <mailhol.vincent@...adoo.fr>
> Sent: Monday, November 28, 2022 5:11 PM
> To: Keller, Jacob E <jacob.e.keller@...el.com>
> Cc: Jiri Pirko <jiri@...dia.com>; netdev@...r.kernel.org; Jakub Kicinski
> <kuba@...nel.org>; David S . Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Paolo Abeni <pabeni@...hat.com>; linux-
> kernel@...r.kernel.org; Boris Brezillon <bbrezillon@...nel.org>; Arnaud Ebalard
> <arno@...isbad.org>; Srujana Challa <schalla@...vell.com>; Kurt Kanzenbach
> <kurt@...utronix.de>; Andrew Lunn <andrew@...n.ch>; Florian Fainelli
> <f.fainelli@...il.com>; Vladimir Oltean <olteanv@...il.com>; Michael Chan
> <michael.chan@...adcom.com>; Ioana Ciornei <ioana.ciornei@....com>;
> Dimitris Michailidis <dmichail@...gible.com>; Yisen Zhuang
> <yisen.zhuang@...wei.com>; Salil Mehta <salil.mehta@...wei.com>;
> Brandeburg, Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; Sunil Goutham <sgoutham@...vell.com>; Linu
> Cherian <lcherian@...vell.com>; Geetha sowjanya <gakula@...vell.com>;
> Jerin Jacob <jerinj@...vell.com>; hariprasad <hkelam@...vell.com>;
> Subbaraya Sundeep <sbhatta@...vell.com>; Taras Chornyi
> <tchornyi@...vell.com>; Saeed Mahameed <saeedm@...dia.com>; Leon
> Romanovsky <leon@...nel.org>; Ido Schimmel <idosch@...dia.com>; Petr
> Machata <petrm@...dia.com>; Simon Horman <simon.horman@...igine.com>;
> Shannon Nelson <snelson@...sando.io>; drivers@...sando.io; Ariel Elior
> <aelior@...vell.com>; Manish Chopra <manishc@...vell.com>; Jonathan
> Lemon <jonathan.lemon@...il.com>; Vadim Fedorenko <vadfed@...com>;
> Richard Cochran <richardcochran@...il.com>; Vadim Pasternak
> <vadimp@...lanox.com>; linux-crypto@...r.kernel.org; intel-wired-
> lan@...ts.osuosl.org; linux-rdma@...r.kernel.org; oss-drivers@...igine.com; Jiri
> Pirko <jiri@...lanox.com>; Herbert Xu <herbert@...dor.apana.org.au>;
> Guangbin Huang <huangguangbin2@...wei.com>; Minghao Chi
> <chi.minghao@....com.cn>; Shijith Thotton <sthotton@...vell.com>
> Subject: Re: [PATCH net-next v5 2/4] net: devlink: remove
> devlink_info_driver_name_put()
>
> Hi Jacob,
>
> Thanks for the review!
>
> On Tue. 29 Nov. 2022 at 09:23, Keller, Jacob E <jacob.e.keller@...el.com> wrote:
> > > -----Original Message-----
> > > From: Vincent Mailhol <vincent.mailhol@...il.com> On Behalf Of Vincent
> > > Mailhol
> > > Sent: Monday, November 28, 2022 4:06 PM
> > > To: Jiri Pirko <jiri@...dia.com>; netdev@...r.kernel.org; Jakub Kicinski
> > > <kuba@...nel.org>
> > > Cc: David S . Miller <davem@...emloft.net>; Eric Dumazet
> > > <edumazet@...gle.com>; Paolo Abeni <pabeni@...hat.com>; linux-
> > > kernel@...r.kernel.org; Boris Brezillon <bbrezillon@...nel.org>; Arnaud
> Ebalard
> > > <arno@...isbad.org>; Srujana Challa <schalla@...vell.com>; Kurt
> Kanzenbach
> > > <kurt@...utronix.de>; Andrew Lunn <andrew@...n.ch>; Florian Fainelli
> > > <f.fainelli@...il.com>; Vladimir Oltean <olteanv@...il.com>; Michael Chan
> > > <michael.chan@...adcom.com>; Ioana Ciornei <ioana.ciornei@....com>;
> > > Dimitris Michailidis <dmichail@...gible.com>; Yisen Zhuang
> > > <yisen.zhuang@...wei.com>; Salil Mehta <salil.mehta@...wei.com>;
> > > Brandeburg, Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L
> > > <anthony.l.nguyen@...el.com>; Sunil Goutham <sgoutham@...vell.com>;
> Linu
> > > Cherian <lcherian@...vell.com>; Geetha sowjanya <gakula@...vell.com>;
> > > Jerin Jacob <jerinj@...vell.com>; hariprasad <hkelam@...vell.com>;
> > > Subbaraya Sundeep <sbhatta@...vell.com>; Taras Chornyi
> > > <tchornyi@...vell.com>; Saeed Mahameed <saeedm@...dia.com>; Leon
> > > Romanovsky <leon@...nel.org>; Ido Schimmel <idosch@...dia.com>; Petr
> > > Machata <petrm@...dia.com>; Simon Horman
> <simon.horman@...igine.com>;
> > > Shannon Nelson <snelson@...sando.io>; drivers@...sando.io; Ariel Elior
> > > <aelior@...vell.com>; Manish Chopra <manishc@...vell.com>; Jonathan
> > > Lemon <jonathan.lemon@...il.com>; Vadim Fedorenko <vadfed@...com>;
> > > Richard Cochran <richardcochran@...il.com>; Vadim Pasternak
> > > <vadimp@...lanox.com>; Shalom Toledo <shalomt@...lanox.com>; linux-
> > > crypto@...r.kernel.org; intel-wired-lan@...ts.osuosl.org; linux-
> > > rdma@...r.kernel.org; oss-drivers@...igine.com; Jiri Pirko
> > > <jiri@...lanox.com>; Herbert Xu <herbert@...dor.apana.org.au>; Hao
> Chen
> > > <chenhao288@...ilicon.com>; Guangbin Huang
> > > <huangguangbin2@...wei.com>; Minghao Chi <chi.minghao@....com.cn>;
> > > Shijith Thotton <sthotton@...vell.com>; Vincent Mailhol
> > > <mailhol.vincent@...adoo.fr>
> > > Subject: [PATCH net-next v5 2/4] net: devlink: remove
> > > devlink_info_driver_name_put()
> > >
> > > Now that the core sets the driver name attribute, drivers are not
> > > supposed to call devlink_info_driver_name_put() anymore. Remove it.
> > >
> >
> > You could combine this patch with the previous one so that in the event of a
> cherry-pick its not possible to have this function while the core inserts the driver
> name automatically.
> >
> > I think that also makes it very clear that there are no remaining in-tree drivers
> still calling the function.
> >
> > I don't have a strong preference if we prefer it being separated.
>
> The first patch is already pretty long. I do not expect this to be
> cherry-picked because it does not fix any existing bug (and if people
> really want to cherry pick, then they just have to cherry pick both).
> On the contrary, splitting makes it easier to review, I think.
>
> Unless the maintainers as me to squash, I want to keep it as-is.
>
That works for me!
Thanks,
Jake
>
> Yours sincerely,
> Vincent Mailhol
Powered by blists - more mailing lists