linux-kernel - Re: [PATCH rdma-next] RDMA/mlx4: remove NULL check before dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 29 Nov 2022 11:21:55 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     zhang.songyi@....com.cn
Cc:     jgg@...pe.ca, linux-rdma@...r.kernel.org,
        zhangsongyi.cgel@...il.com, yishaih@...dia.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH rdma-next] RDMA/mlx4: remove NULL check before dev_{put, hold}

On Tue, 29 Nov 2022 15:54:07 +0800 (CST), zhang.songyi@....com.cn wrote:
> From: zhang songyi <zhang.songyi@....com.cn>
> 
> The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> so there is no need to check before using dev_{put, hold}.
> 
> Fix the following coccicheck warnings:
> /drivers/infiniband/hw/mlx4/main.c:1311:2-10: WARNING:
> WARNING  NULL check before dev_{put, hold} functions is not needed.
> 
> [...]

Applied, thanks!

[1/1] RDMA/mlx4: remove NULL check before dev_{put, hold}
      https://git.kernel.org/rdma/rdma/c/7ff54cf9f514c2

Best regards,
-- 
Leon Romanovsky <leon@...nel.org>