linux-kernel - [PATCH v2 1/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix error in example (bogus include)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Nov 2022 11:22:24 +0100
From:   Jonathan Neuschäfer <j.neuschaefer@....net>
To:     linux-spi@...r.kernel.org, Mark Brown <broonie@...nel.org>
Cc:     Conor Dooley <conor.dooley@...rochip.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>, openbmc@...ts.ozlabs.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Jonathan Neuschäfer <j.neuschaefer@....net>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Subject: [PATCH v2 1/2] spi: dt-bindings: nuvoton,wpcm450-fiu: Fix error in example (bogus include)

The nuvoton,wpcm450-fiu binding's example includes
nuvoton,wpcm450-clk.h, which has not been merged yet,
thus causing a dt_binding_check error on -next.

Fix this error by simply hardcoding the clock index in the example,
before the breakage spreads any further.

Fixes: dd71cd4dd6c9b ("spi: Add Nuvoton WPCM450 Flash Interface Unit (FIU) bindings")
Reported-by: Rob Herring <robh@...nel.org>
Reported-by: Conor Dooley <conor.dooley@...rochip.com>
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
---

v2:
- Credit Rob Herring as well (Rob's bot reported the issue, Conor made
  me aware that it is a problem that has found its way into linux-next)
---
 Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml b/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
index ef94803e75d90..e4162845fcc1d 100644
--- a/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
+++ b/Documentation/devicetree/bindings/spi/nuvoton,wpcm450-fiu.yaml
@@ -45,14 +45,13 @@ unevaluatedProperties: false

 examples:
   - |
-    #include <dt-bindings/clock/nuvoton,wpcm450-clk.h>
     spi@...00000 {
       compatible = "nuvoton,wpcm450-fiu";
       reg = <0xc8000000 0x1000>, <0xc0000000 0x4000000>;
       #address-cells = <1>;
       #size-cells = <0>;
       reg-names = "control", "memory";
-      clocks = <&clk WPCM450_CLK_FIU>;
+      clocks = <&clk 0>;
       nuvoton,shm = <&shm>;

       flash@0 {
--
2.35.1