linux-kernel - Re: [PATCH] fpga: stratix10-soc: Fix return value check in s10_ops_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Nov 2022 17:26:23 -0800
From:   Russ Weight <russell.h.weight@...el.com>
To:     Zheng Yongjun <zhengyongjun3@...wei.com>, <mdf@...nel.org>,
        <hao.wu@...el.com>, <yilun.xu@...el.com>,
        <linux-fpga@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:     <trix@...hat.com>
Subject: Re: [PATCH] fpga: stratix10-soc: Fix return value check in
 s10_ops_write_init()



On 11/25/22 23:14, Zheng Yongjun wrote:
> In case of error, the function stratix10_svc_allocate_memory()
> returns ERR_PTR() and never returns NULL. The NULL test in the
> return value check should be replaced with IS_ERR().
>
> Fixes: e7eef1d7633a ("fpga: add intel stratix10 soc fpga manager driver")

Reviewed-by: Russ Weight <russell.h.weight@...el.com>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@...wei.com>
> ---
>  drivers/fpga/stratix10-soc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> index 357cea58ec98..f7f01982a512 100644
> --- a/drivers/fpga/stratix10-soc.c
> +++ b/drivers/fpga/stratix10-soc.c
> @@ -213,9 +213,9 @@ static int s10_ops_write_init(struct fpga_manager *mgr,
>  	/* Allocate buffers from the service layer's pool. */
>  	for (i = 0; i < NUM_SVC_BUFS; i++) {
>  		kbuf = stratix10_svc_allocate_memory(priv->chan, SVC_BUF_SIZE);
> -		if (!kbuf) {
> +		if (IS_ERR(kbuf)) {
>  			s10_free_buffers(mgr);
> -			ret = -ENOMEM;
> +			ret = PTR_ERR(kbuf);
>  			goto init_done;
>  		}
>
> --
> 2.17.1
>