[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CABk29NsyhxiOnE7ssJpPEvgFV2_em1k2=9Yy3nMG9z9TssbBNA@mail.gmail.com>
Date: Mon, 28 Nov 2022 17:32:15 -0800
From: Josh Don <joshdon@...gle.com>
To: Peter Zijlstra <peterz@...radead.org>
Cc: Chengming Zhou <zhouchengming@...edance.com>,
Ingo Molnar <mingo@...hat.com>,
Juri Lelli <juri.lelli@...hat.com>,
Vincent Guittot <vincent.guittot@...aro.org>,
Dietmar Eggemann <dietmar.eggemann@....com>,
Steven Rostedt <rostedt@...dmis.org>,
Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
Daniel Bristot de Oliveira <bristot@...hat.com>,
Valentin Schneider <vschneid@...hat.com>,
linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>,
Michal Koutný <mkoutny@...e.com>,
Christian Brauner <brauner@...nel.org>,
Zefan Li <lizefan.x@...edance.com>,
Thomas Gleixner <tglx@...utronix.de>,
Frederic Weisbecker <fweisbec@...il.com>,
anna-maria@...utronix.de
Subject: Re: [PATCH v3] sched: async unthrottling for cfs bandwidth
> @@ -1686,7 +1698,17 @@ static void __run_hrtimer(struct hrtimer_cpu_base *cpu_base,
>
> lockdep_hrtimer_exit(expires_in_hardirq);
> trace_hrtimer_expire_exit(timer);
> - raw_spin_lock_irq(&cpu_base->lock);
> +
> + local_irq_disable();
> +
> + if (restart >= HRTIMER_RESTART_MIGRATE) {
> + int cpu = restart - HRTIMER_RESTART_MIGRATE;
I know this is just a rough draft, but just noting that this wants a
check against MIGRATE_MAX :)
> + if (new_cpu_base != cpu_base) {
> + timer->base = new_base;
> + enqueue_hrtimer(timer, new_base, HRTIMER_MODE_ABS);
> + raw_spin_unlock(&new_cpu_base->lock);
unlock the old base->lock right?
Powered by blists - more mailing lists