linux-kernel - Re: [PATCH] dt-bindings: mmc: Make comment on wakeup-source less confusing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb035398-ba56-0ce0-3b14-b8dc5863b7f3@linaro.org>
Date:   Tue, 29 Nov 2022 13:33:42 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Ulf Hansson <ulf.hansson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     Christoph Niedermaier <cniedermaier@...electronics.com>,
        linux-kernel@...r.kernel.org, Marek Vasut <marex@...x.de>,
        kernel@...electronics.com, linux-mmc@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: Make comment on wakeup-source less
 confusing

On 29/11/2022 13:06, Ulf Hansson wrote:
> On Tue, 22 Nov 2022 at 12:43, Christoph Niedermaier
> <cniedermaier@...electronics.com> wrote:
>>
>> The current comment on wakeup-source is a bit confusing, because it isn't
>> clear at first sight which property is actually deprecated.
>> Change the comment to one that is less confusing.
>>
>> Signed-off-by: Christoph Niedermaier <cniedermaier@...electronics.com>
>> ---
>> Cc: Ulf Hansson <ulf.hansson@...aro.org>
>> Cc: Rob Herring <robh+dt@...nel.org>
>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
>> Cc: Marek Vasut <marex@...x.de>
>> Cc: kernel@...electronics.com
>> Cc: linux-mmc@...r.kernel.org
>> Cc: devicetree@...r.kernel.org
>> To: linux-kernel@...r.kernel.org
>> ---
>>  Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
>> index 802e3ca8be4d..a921442c6c1d 100644
>> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
>> @@ -293,7 +293,7 @@ properties:
>>      description:
>>        SDIO only. Preserves card power during a suspend/resume cycle.
>>
>> -  # Deprecated: enable-sdio-wakeup
>> +  # Use wakeup-source instead of the deprecated enable-sdio-wakeup
>>    wakeup-source:
>>      $ref: /schemas/types.yaml#/definitions/flag
>>      description:
> 
> Rob, Krzysztof - do we have a preferred pattern for how to express
> deprecated bindings - or is the above okay to you?

Yes, we have:
  deprecated: true

I don't get why this is in response to LED patch? I entirely ignored
this thread because of it.


Best regards,
Krzysztof