[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55c29f92-4c6b-266f-2004-ae633a658963@linaro.org>
Date: Tue, 29 Nov 2022 13:35:59 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Christoph Niedermaier <cniedermaier@...electronics.com>,
linux-kernel@...r.kernel.org
Cc: Ulf Hansson <ulf.hansson@...aro.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Marek Vasut <marex@...x.de>, kernel@...electronics.com,
linux-mmc@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: Make comment on wakeup-source less
confusing
On 22/11/2022 12:11, Christoph Niedermaier wrote:
> The current comment on wakeup-source is a bit confusing, because it isn't
> clear at first sight which property is actually deprecated.
> Change the comment to one that is less confusing.
It's still confusing - you mention some non-existing property. I don't
think it's worth to touch it. If you insist, drop entire comment...
>
> Signed-off-by: Christoph Niedermaier <cniedermaier@...electronics.com>
> ---
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
> Cc: Marek Vasut <marex@...x.de>
> Cc: kernel@...electronics.com
> Cc: linux-mmc@...r.kernel.org
> Cc: devicetree@...r.kernel.org
> To: linux-kernel@...r.kernel.org
> ---
> Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 802e3ca8be4d..a921442c6c1d 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -293,7 +293,7 @@ properties:
> description:
> SDIO only. Preserves card power during a suspend/resume cycle.
>
> - # Deprecated: enable-sdio-wakeup
> + # Use wakeup-source instead of the deprecated enable-sdio-wakeup
> wakeup-source:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
Best regards,
Krzysztof
Powered by blists - more mailing lists