| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <6d328461-d705-9e82-ccf3-dec8885f17fe@suse.de>
Date: Tue, 29 Nov 2022 15:00:52 +0100
From: Andreas Färber <afaerber@...e.de>
To: Chester Lin <clin@...e.com>, Rob Herring <robh+dt@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc: s32@....com, linux-gpio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
Larisa Grigore <larisa.grigore@....com>,
Ghennadi Procopciuc <Ghennadi.Procopciuc@....com>,
Andrei Stefanescu <andrei.stefanescu@....com>,
Matthias Brugger <mbrugger@...e.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: add schema for NXP S32 SoCs
Hi Chester,
Am 28.11.22 um 06:48 schrieb Chester Lin:
> Add DT schema for the pinctrl driver of NXP S32 SoC family.
>
> Signed-off-by: Larisa Grigore <larisa.grigore@....com>
> Signed-off-by: Ghennadi Procopciuc <Ghennadi.Procopciuc@....com>
> Signed-off-by: Andrei Stefanescu <andrei.stefanescu@....com>
> Signed-off-by: Chester Lin <clin@...e.com>
> ---
>
> Changes in v2:
> - Remove the "nxp,pins" property since it has been moved into the driver.
> - Add descriptions for reg entries.
> - Refine the compatible name from "nxp,s32g-..." to "nxp,s32g2-...".
Thanks.
> - Fix schema issues and revise the example.
> - Fix the copyright format suggested by NXP.
>
> .../pinctrl/nxp,s32cc-siul2-pinctrl.yaml | 125 ++++++++++++++++++
> 1 file changed, 125 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/nxp,s32cc-siul2-pinctrl.yaml
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/nxp,s32cc-siul2-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/nxp,s32cc-siul2-pinctrl.yaml
> new file mode 100644
> index 000000000000..2fc25a9362af
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/nxp,s32cc-siul2-pinctrl.yaml
> @@ -0,0 +1,125 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
Any reason the code is GPL-2.0-or-later but the schema is GPL-2.0-only?
> +# Copyright 2022 NXP
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/nxp,s32cc-siul2-pinctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP S32 Common Chassis SIUL2 iomux controller
> +
> +maintainers:
> + - Ghennadi Procopciuc <Ghennadi.Procopciuc@....com>
> + - Chester Lin <clin@...e.com>
> +
> +description: |
> + Core driver for the pin controller found on S32 Common Chassis SoC.
SoC family
> +
> +properties:
> + compatible:
> + enum:
> + - nxp,s32g2-siul2-pinctrl
> +
> + reg:
> + description:
> + A list of MSCR/IMCR register regions to be reserved.
> + - MSCR (Multiplexed Signal Configuration Register)
> + An MSCR register can configure the associated pin as either a GPIO pin
> + or a function output pin depends on the selected signal source.
> + - IMCR (Input Multiplexed Signal Configuration Register)
> + An IMCR register can configure the associated pin as function input
> + pin depends on the selected signal source.
Does this multi-paragraph text not need "description: |" like above?
> + minItems: 5
> + items:
> + - description: MSCR registers group 0 managed by the SIUL2 controller 0
> + - description: MSCR registers group 1 managed by the SIUL2 controller 1
> + - description: MSCR registers group 2 managed by the SIUL2 controller 1
> + - description: IMCR registers group 0 managed by the SIUL2 controller 0
> + - description: IMCR registers group 1 managed by the SIUL2 controller 1
> + - description: IMCR registers group 2 managed by the SIUL2 controller 1
> +
> +required:
> + - compatible
> + - reg
> +
> +patternProperties:
> + '-pins$':
> + type: object
> + additionalProperties: false
> +
> + patternProperties:
> + '-grp[0-9]$':
> + type: object
> + allOf:
> + - $ref: pinmux-node.yaml#
> + - $ref: pincfg-node.yaml#
> + unevaluatedProperties: false
> + description:
> + Pinctrl node's client devices specify pin muxes using subnodes,
> + which in turn use the standard properties.
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> +
> + /* Pins functions (SSS field) */
> + #define FUNC0 0
> + #define FUNC1 1
> + #define FUNC2 2
> + #define FUNC3 3
> + #define FUNC4 4
> + #define FUNC5 5
> + #define FUNC6 6
> + #define FUNC7 7
> +
> + #define S32CC_PINMUX(PIN, FUNC) (((PIN) << 4) | (FUNC))
> +
> + #define S32CC_SLEW_208MHZ 0
> + #define S32CC_SLEW_166MHZ 4
> + #define S32CC_SLEW_150MHZ 5
> + #define S32CC_SLEW_133MHZ 6
> + #define S32CC_SLEW_83MHZ 7
I notice that neither this patch nor the following one introduces a
dt-bindings header for these macros? Is the plan to only have them in
TF-A sources? Thinking of DT overlays for SoMs, for example.
Regards,
Andreas
> +
> + pinctrl@...9c240 {
> + compatible = "nxp,s32g2-siul2-pinctrl";
> +
> + /*
> + * There are two SIUL2 controllers in S32G2:
> + *
> + * siul2_0 @ 0x4009c000
> + * siul2_1 @ 0x44010000
> + *
> + * Every SIUL2 controller has multiple register types, and here
> + * only MSCR and IMCR registers need to be revealed for kernel
> + * to configure pinmux. Please note that some indexes are reserved,
> + * such as MSCR102-MSCR111 in the following reg property.
> + */
> +
> + /* MSCR0-MSCR101 registers on siul2_0 */
> + reg = <0x4009c240 0x198>,
> + /* MSCR112-MSCR122 registers on siul2_1 */
> + <0x44010400 0x2c>,
> + /* MSCR144-MSCR190 registers on siul2_1 */
> + <0x44010480 0xbc>,
> + /* IMCR0-IMCR83 registers on siul2_0 */
> + <0x4009ca40 0x150>,
> + /* IMCR119-IMCR397 registers on siul2_1 */
> + <0x44010c1c 0x45c>,
> + /* IMCR430-IMCR495 registers on siul2_1 */
> + <0x440110f8 0x108>;
> +
> + llce-can0-pins {
> + llce-can0-grp0 {
> + pinmux = <S32CC_PINMUX(43, FUNC0)>;
> + input-enable;
> + slew-rate = <S32CC_SLEW_208MHZ>;
> + };
> +
> + llce-can0-grp1 {
> + pinmux = <S32CC_PINMUX(44, FUNC2)>;
> + output-enable;
> + slew-rate = <S32CC_SLEW_208MHZ>;
> + };
> + };
> + };
> +...
--
SUSE Software Solutions Germany GmbH
Frankenstraße 146, 90461 Nürnberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nürnberg)
Powered by blists - more mailing lists