linux-kernel - Re: [PATCH] ieee802154: cc2520: Fix error return code in cc2520_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 29 Nov 2022 15:01:01 +0100
From:   Stefan Schmidt <stefan@...enfreihafen.org>
To:     Ziyang Xuan <william.xuanziyang@...wei.com>,
        varkabhadram@...il.com, alex.aring@...il.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        linux-wpan@...r.kernel.org, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ieee802154: cc2520: Fix error return code in
 cc2520_hw_init()

Hello.

On 20.11.22 08:50, Ziyang Xuan wrote:
> In cc2520_hw_init(), if oscillator start failed, the error code
> should be returned.
> 
> Fixes: 0da6bc8cc341 ("ieee802154: cc2520: adds driver for TI CC2520 radio")
> Signed-off-by: Ziyang Xuan <william.xuanziyang@...wei.com>
> ---
>   drivers/net/ieee802154/cc2520.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
> index c69b87d3837d..edc769daad07 100644
> --- a/drivers/net/ieee802154/cc2520.c
> +++ b/drivers/net/ieee802154/cc2520.c
> @@ -970,7 +970,7 @@ static int cc2520_hw_init(struct cc2520_private *priv)
>   
>   		if (timeout-- <= 0) {
>   			dev_err(&priv->spi->dev, "oscillator start failed!\n");
> -			return ret;
> +			return -ETIMEDOUT;
>   		}
>   		udelay(1);
>   	} while (!(status & CC2520_STATUS_XOSC32M_STABLE));

This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt