linux-kernel - Re: [PATCH v2 1/5] dt-bindings: net: snps, dwmac: add NXP S32CC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d9c0d89-15c1-bd10-18ac-2e10d451c20f@suse.de>
Date:   Tue, 29 Nov 2022 15:10:18 +0100
From:   Andreas Färber <afaerber@...e.de>
To:     Chester Lin <clin@...e.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Jose Abreu <joabreu@...opsys.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     netdev@...r.kernel.org, s32@....com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Matthias Brugger <mbrugger@...e.com>,
        Jan Petrous <jan.petrous@....com>
Subject: Re: [PATCH v2 1/5] dt-bindings: net: snps, dwmac: add NXP S32CC
 support

Hi Chester,

Am 28.11.22 um 06:49 schrieb Chester Lin:
> Add a new compatible string for NXP S32CC DWMAC glue driver. The maxItems
> of clock and clock-names need be increased because S32CC has up to 11
> clocks for its DWMAC.
> 
> Signed-off-by: Chester Lin <clin@...e.com>
> ---
> 
> No change in v2.
> 
>   Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 13b984076af5..c174d173591e 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -65,6 +65,7 @@ properties:
>           - ingenic,x2000-mac
>           - loongson,ls2k-dwmac
>           - loongson,ls7a-dwmac
> +        - nxp,s32cc-dwmac

As we had discussed offline, please change this to nxp,s32g2-dwmac.
S32G3 and S32R45 can then reuse it if they don't require changes; there 
is no difference here to how i.MX family or other vendors inherit IP 
across SoC models, so Rob's rules apply equally.

Also affects the following patches.

Thanks,
Andreas

>           - renesas,r9a06g032-gmac
>           - renesas,rzn1-gmac
>           - rockchip,px30-gmac
[snip]

-- 
SUSE Software Solutions Germany GmbH
Frankenstraße 146, 90461 Nürnberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nürnberg)