[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CADnq5_OkpKY25gPQJWVGb859EJrG2uqL4J9DW_Yiut9iN6AhKQ@mail.gmail.com>
Date: Tue, 29 Nov 2022 10:27:55 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: Konstantin Meskhidze <konstantin.meskhidze@...wei.com>
Cc: alexander.deucher@....com, yifan1.zhang@....com,
lijo.lazar@....com, yusongping@...wei.com, guchun.chen@....com,
artem.kuzin@...wei.com, Xinhui.Pan@....com,
linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
mdaenzer@...hat.com, nirmoy.das@....com,
dri-devel@...ts.freedesktop.org, hukeping@...wei.com,
evan.quan@....com, christian.koenig@....com, Hawking.Zhang@....com
Subject: Re: [PATCH] drm: amdgpu: Fix logic error
Applied. Thanks!
Alex
On Tue, Nov 29, 2022 at 2:49 AM Konstantin Meskhidze
<konstantin.meskhidze@...wei.com> wrote:
>
> This commit fixes logic error in function 'amdgpu_hw_ip_info':
> - value 'uvd' might be 'vcn'.
>
> Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@...wei.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> index fe23e09eec98..28752a6a92c4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
> @@ -424,7 +424,7 @@ static int amdgpu_hw_ip_info(struct amdgpu_device *adev,
> case AMDGPU_HW_IP_VCN_DEC:
> type = AMD_IP_BLOCK_TYPE_VCN;
> for (i = 0; i < adev->vcn.num_vcn_inst; i++) {
> - if (adev->uvd.harvest_config & (1 << i))
> + if (adev->vcn.harvest_config & (1 << i))
> continue;
>
> if (adev->vcn.inst[i].ring_dec.sched.ready)
> @@ -436,7 +436,7 @@ static int amdgpu_hw_ip_info(struct amdgpu_device *adev,
> case AMDGPU_HW_IP_VCN_ENC:
> type = AMD_IP_BLOCK_TYPE_VCN;
> for (i = 0; i < adev->vcn.num_vcn_inst; i++) {
> - if (adev->uvd.harvest_config & (1 << i))
> + if (adev->vcn.harvest_config & (1 << i))
> continue;
>
> for (j = 0; j < adev->vcn.num_enc_rings; j++)
> --
> 2.25.1
>
Powered by blists - more mailing lists