[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <dad4d480-8c72-46da-b0ad-4a8235bb03cf@9elements.com>
Date: Tue, 29 Nov 2022 21:22:22 +0530
From: Naresh Solanki <naresh.solanki@...ements.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
devicetree@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>,
Jean Delvare <jdelvare@...e.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Roland Stigge <stigge@...com.de>
Cc: linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
Patrick Rudolph <patrick.rudolph@...ements.com>,
Marcello Sylvester Bauer <sylv@...v.io>
Subject: Re: [PATCH v7 2/4] dt-bindings: hwmon: Add binding for max6639
Hi Krzysztof,
On 29-11-2022 01:44 pm, Krzysztof Kozlowski wrote:
> On 21/11/2022 13:29, Naresh Solanki wrote:
>> From: Marcello Sylvester Bauer <sylv@...v.io>
>>
>> Add Devicetree binding documentation for Maxim MAX6639 temperature
>> monitor with PWM fan-speed controller.
>>
>> Signed-off-by: Marcello Sylvester Bauer <sylv@...v.io>
>> Signed-off-by: Naresh Solanki <Naresh.Solanki@...ements.com>
>> ---
>> .../bindings/hwmon/maxim,max6639.yaml | 93 +++++++++++++++++++
>> 1 file changed, 93 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
>> new file mode 100644
>> index 000000000000..da040b11d2ab
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
>> @@ -0,0 +1,93 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +
>> +$id: http://devicetree.org/schemas/hwmon/maxim,max6639.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Maxim max6639
>> +
>> +maintainers:
>> + - Roland Stigge <stigge@...com.de>
>> +
>> +description: |
>> + The MAX6639 is a 2-channel temperature monitor with dual, automatic, PWM
>> + fan-speed controller. It monitors its own temperature and one external
>> + diode-connected transistor or the temperatures of two external diode-connected
>> + transistors, typically available in CPUs, FPGAs, or GPUs.
>> +
>> + Datasheets:
>> + https://datasheets.maximintegrated.com/en/ds/MAX6639-MAX6639F.pdf
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - maxim,max6639
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + '#address-cells':
>> + const: 1
>> +
>> + '#size-cells':
>> + const: 0
>> +
>> + '#pwm-cells':
>> + const: 3
>> +
>> +required:
>> + - compatible
>> + - reg
>> +
>> +patternProperties:
>> + "^fan@[0-1]$":
>> + type: object
>> + description: |
>> + Represents the two fans and their specific configuration.
>> +
>> + $ref: fan-common.yaml#
>
> unevalauatedProperties: false
>
Sure
>> +
>> + properties:
>> + reg:
>> + description: |
>> + The fan number.
>> + items:
>> + minimum: 0
>> + maximum: 1
>
> This is a bit unusual syntax. Drop "items", I think it should be more
> obvious.
>
Sure
>> +
>> + required:
>> + - reg
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + i2c {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + fan1: fan-controller@10 {
>> + compatible = "maxim,max6639";
>> + reg = <0x10>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + #pwm-cells = <3>;
>> +
>> + fan@0 {
>> + reg = <0x0>;
>> + pulses-per-revolution = <2>;
>> + max-rpm = <4000>;
>> + target-rpm = <1000>;
>> + pwms = <&fan1 0 25000 0>;
>> + };
>> +
>> + fan@1 {
>> + reg = <0x1>;
>> + pulses-per-revolution = <2>;
>> + max-rpm = <8000>;
>> + pwms = <&fan1 1 25000 0>;
>> + };
>> + };
>
> Fix indentation.
>
Sure
>> + };
>> +...
>
> Best regards,
> Krzysztof
>
Regards,
Naresh
Powered by blists - more mailing lists