linux-kernel - Re: [PATCH v7 4/6] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4YrLbJltvzWvXoy@cmpxchg.org>
Date:   Tue, 29 Nov 2022 10:54:21 -0500
From:   Johannes Weiner <hannes@...xchg.org>
To:     Sergey Senozhatsky <senozhatsky@...omium.org>
Cc:     Vitaly Wool <vitaly.wool@...sulko.com>,
        Nhat Pham <nphamcs@...il.com>, akpm@...ux-foundation.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        minchan@...nel.org, ngupta@...are.org, sjenning@...hat.com,
        ddstreet@...e.org
Subject: Re: [PATCH v7 4/6] zsmalloc: Add a LRU to zs_pool to keep track of
 zspages in LRU order

On Tue, Nov 29, 2022 at 11:03:45PM +0900, Sergey Senozhatsky wrote:
> On (22/11/29 12:53), Vitaly Wool wrote:
> > I think the amount of #ifdefs here becomes absolutely overwhelming.
> > Not that zsmalloc code was very readable before, but now it is
> > starting to look like a plain disaster.
> 
> Presumably most of them will go away once LRU moved from
> allocator to upper level.

Yes consider it the "cut here" lines for refactoring the LRU into
zswap, which we want to do next. They're not here to stay, and that
work will remove a lot of duplication and complexity from all
backends. So I hope it's acceptable as a transitionary state.